Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 70671ba
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ed587dc
Choose a head ref
  • 10 commits
  • 22 files changed
  • 7 contributors

Commits on Oct 28, 2024

  1. Switch some mac_unopt tests from intel to arm hosts (#55882)

    @zanderso
    zanderso authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1af2217 View commit details
    Browse the repository at this point in the history

  2. Pin local_engine mac builds to arm64 (#56172)

    @zanderso
    zanderso authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b59d44e View commit details
    Browse the repository at this point in the history

  3. Roll buildroot to pick up revert of debugging gen_snapshot prints (#5… 

    …6175)

Changes since last roll

```
3f1a1f0 Revert "For --time'd failed gn_run_binary.py runs repeat failed command (#910)" (#914)
e256f5c Remove github actions from buildroot (#913)
```
    @aam
    aam authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c9dd690 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 35ad4e89212f to 21035cd95b68 (1 revision) (#56176) 

    https://skia.googlesource.com/skia.git/+log/35ad4e89212f..21035cd95b68

2024-10-28 [email protected] base: include minimum header for x86 SIMD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ab9717c View commit details
    Browse the repository at this point in the history

  5. Migrate PlatformViewIOS to ARC (#55672) 

    Migrates PlatformViewIOS from manual reference counting to ARC. Eliminates use of scoped_nsobject, scoped_nsprotocol, and WeakNSObject.

Since this is the last non-ARC file in `flutter_framework_source`, this also eliminates the `flutter_framework_source` target, then also renames the `flutter_framework_source_arc` target to `flutter_framework_source` since... it's ALL ARC.

No semantic changes, therefore no semantic changes to tests.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8c74f3f View commit details
    Browse the repository at this point in the history

  6. Reverts "Pin local_engine mac builds to arm64 (#56172)" (#56179) 

    <!-- start_original_pr_link -->
Reverts: #56172
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: mysterious infra failures:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20local_engine_builds/2951/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: zanderso
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {chinmaygarde}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
    @auto-submit
    auto-submit[bot] and auto-submit[bot] authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f776ad7 View commit details
    Browse the repository at this point in the history

  7. iOS/macOS: migrate darwin/common to ARC (#56155) 

    Migrates //flutter/shell/platform/darwin/common` targets to ARC. Most of
these were already ARC compatible.

This does add use of the `FLUTTER_ASSERT_ARC` define since that is
defined in a public framework header, but this code has no dependency on
the framework.

This removes `flutter_cflags_objc` and `flutter_cflags_objcc` compile
configs from `availability_version_check_unittests` since that target is
pure C++ and contains no Objective-C code.

No test changes since this there is no semantic change to the code.

Issue: flutter/flutter#137801
    @cbracken
    cbracken authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0b9f56b View commit details
    Browse the repository at this point in the history

  8. Roll Skia from 21035cd95b68 to bdd225968dab (1 revision) (#56178) 

    https://skia.googlesource.com/skia.git/+log/21035cd95b68..bdd225968dab

2024-10-28 [email protected] Roll vulkan-deps from 6bf0a68d2621 to 098ec4c2bd02 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    7f747bd View commit details
    Browse the repository at this point in the history

  9. [Impeller] fix initial layout for loadOp load and incorrect usage of … 

    …host visible textures. (#56148)

Both changes were required to get playground tests validation free with moltenvk. becuase an initial state of undefined means "I don't care what was in this texture before" but that doesn't make sense if we're setting "kLoad" since that explicitly asks vulkan to load the previous contents.

Fixes flutter/flutter#157557
    Jonah Williams authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    44ebf89 View commit details
    Browse the repository at this point in the history

  10. Roll Dart SDK from 69b50768d733 to c9180e9de9e8 (1 revision) (#56180) 

    https://dart.googlesource.com/sdk.git/+log/69b50768d733..c9180e9de9e8

2024-10-28 [email protected] Version 3.7.0-74.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ed587dc View commit details
    Browse the repository at this point in the history
Loading