Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 702f366
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bdeb534
Choose a head ref
  • 6 commits
  • 33 files changed
  • 6 contributors

Commits on Oct 10, 2023

  1. [Impeller] Implement framebuffer fetch support for OpenGLES. (#46585) 

    flutter/flutter#120223 for OpenGLES. Checks for support of the framebuffer fetch extension: https://registry.khronos.org/OpenGL/extensions/EXT/EXT_shader_framebuffer_fetch.txt . This is supported on a Pixel 6 at least, we should double check the distribution of the extension.

![d3c](https://github.com/flutter/engine/assets/8975114/d2392dc8-e1b1-4084-ac5d-c5744c651a39)
    Jonah Williams authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    657af19 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (#46728) 

    https://skia.googlesource.com/skia.git/+log/475286f0f6f1..06145491fd17

2023-10-10 [email protected] [graphite] Add caching for RasterPathAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    d379d53 View commit details
    Browse the repository at this point in the history

  3. Remove workaround for older versions of MSVC. (#46689) 

    We don't use the MSVC frontend now anyway. And haven't for a while.
    @chinmaygarde
    chinmaygarde authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7fb5d07 View commit details
    Browse the repository at this point in the history

  4. Use x86 machines for ios builds. (#46726) 

    This is to workaround rosetta not being installed in dart-internal machines and to unblock beta releases.

Bug: flutter/flutter#136219

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b64b976 View commit details
    Browse the repository at this point in the history

  5. Prepare to move new folders into third_party/ by adding a `.gitigno… 

    …re`. (#46729)

As part of flutter/flutter#67373, we'll be
adding, for example `third_party/glfw`.

This PR will by default ignore folders, except for ones that have
internal repo-sourced code (which are unlikely to change much, if at all
during this transition).

_/cc @Hixie, @chinmaygarde FYI only_.
    @matanlurey
    matanlurey authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c0fcf94 View commit details
    Browse the repository at this point in the history

  6. Fix high FPS screen flicker of Platform Views when using ImageReaderP… 

    …latformViewRenderTarget (#46724)

The root bug (b/300627634) was that we were holding onto HardwareBuffers
after the owning Image was closed. This CL refactors the C++ code to
properly hold a reference to the Image until it is safe to dispose of.

This CL also refactors the Impeller GL and Skia GL code paths to share
more code.
    @johnmccutchan
    johnmccutchan authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    bdeb534 View commit details
    Browse the repository at this point in the history
Loading