-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: 68aa9ba
head repository: flutter/engine
compare: b16c0f1
- 10 commits
- 32 files changed
- 5 contributors
Commits on Mar 28, 2024
-
[macOS] Group per-view information in
FlutterCompositorinto a class (#51738) This PR groups per-view information in `FlutterCompositor` into a private class, `ViewPresenter`. This makes it easier to manage per-view data and write view operations. Part of flutter/flutter#145874. Currently, view presenters are never removed once created, since the macOS runner doesn't support removing views. This will be added in the future. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for c1d6a8e - Browse repository at this point
Copy the full SHA c1d6a8eView commit details
Commits on Mar 29, 2024
-
[Windows] Don't always stop engine on view destruction (#51681)
Currently destroying a view also shuts down the engine. This makes sense as in single-view world where the view also always owns the engine. However, in a multi-view world the views will share the engine. Destroying one view shouldn't necessarily shut down the engine unless that view owns the engine. Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 8f0a2ee - Browse repository at this point
Copy the full SHA 8f0a2eeView commit details -
[Windows] Move keyboard initialization (#51758)
Previously the keyboard was initialized after the view is created. This used to be necessary as the keyboard & text input plugins were strongly tied to a view (and would crash in headless modes). This is no longer necessary, and the keyboard can now be initialized normally as part of the engine initialization. Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for b77fc96 - Browse repository at this point
Copy the full SHA b77fc96View commit details -
Add completion callback to
Shell::AddView(#51659)In the future, `FlutterEngineAddView` will be added to the embedder API to allow embedders to add views. `FlutterEngineAddView` will accept a callback that notifies the embedder once the view has been added. This embedder API will be powered by `Shell::AddView`. This change adds a completion callback to `Shell::AddView` to prepare for the embedder API. Design doc: https://flutter.dev/go/multi-view-embedder-apis Part of flutter/flutter#144806 Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 4ac21cb - Browse repository at this point
Copy the full SHA 4ac21cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71b680f - Browse repository at this point
Copy the full SHA 71b680fView commit details -
[skwasm] Fix
toStringmethods on Paint and ImageFilter/ColorFilter (#……51766) This fixes flutter/flutter#141639 Most of this was previously unimplemented. It turns out the reason for the hang described in the github issue was that there was a typo in the name of the `getMiterLimit` C function, so if the client actually called that method the Wasm module failed to compile, as it couldn't find an import with the misspelled name.
Configuration menu - View commit details
-
Copy full SHA for cc8cd24 - Browse repository at this point
Copy the full SHA cc8cd24View commit details -
Roll Fuchsia Linux SDK from uzI3wnbEGlZ_dtO0Z... to 3vgfbp1vjXkdMZ09m…
…... (#51767) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 5f4765f - Browse repository at this point
Copy the full SHA 5f4765fView commit details -
Roll Skia from 6042ad386bcf to b2a01ae03cdf (4 revisions) (#51772)
https://skia.googlesource.com/skia.git/+log/6042ad386bcf..b2a01ae03cdf 2024-03-29 [email protected] Roll Skia Infra from d9a2f3150285 to 33ace26e29f4 (9 revisions) 2024-03-29 [email protected] Roll Dawn from 8220ee868483 to 2126889e45aa (11 revisions) 2024-03-29 [email protected] Roll SwiftShader from f0178b3c40e7 to ff61926fcedb (2 revisions) 2024-03-29 [email protected] Roll vulkan-deps from 61c7aa9a8478 to f91c2fe47c47 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 0a4876a - Browse repository at this point
Copy the full SHA 0a4876aView commit details -
Roll Skia from b2a01ae03cdf to 94c0af1297ae (1 revision) (#51773)
https://skia.googlesource.com/skia.git/+log/b2a01ae03cdf..94c0af1297ae 2024-03-29 [email protected] Roll ANGLE from 21b6899a9c31 to 2b66694d37de (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 6fee660 - Browse repository at this point
Copy the full SHA 6fee660View commit details -
Roll Skia from 94c0af1297ae to a12e40efacea (3 revisions) (#51776)
https://skia.googlesource.com/skia.git/+log/94c0af1297ae..a12e40efacea 2024-03-29 [email protected] fix indentation in SkBlitMask_opts.h 2024-03-29 [email protected] Remove deprecated hasMipMaps from GrBackendSurface 2024-03-29 [email protected] Roll SK Tool from 33ace26e29f4 to dc19502e745f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b16c0f1 - Browse repository at this point
Copy the full SHA b16c0f1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 68aa9ba...b16c0f1