Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 59b6b94
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1bb228d
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Oct 6, 2023

  1. [Impeller] Track clip coverage per-pass when not collapsing. (#46597) 

    Resolves flutter/flutter#135916.

Big credits to @gaaclarke for the repros and investigation around this.

Moves back to tracking clip coverage per-pass when not collapsing. This is especially important for SaveLayers with MatrixImageFilters, which can transform the rendered layer texture and thereby move elements inside or outside of existing parent clips.

This should have little to no performance impact, since we should already be generating correct minimal subpass textures based on correct subpass coverage computation.

Before:
<img width="679" alt="Screenshot 2023-10-05 at 1 25 29 PM" src="https://github.com/flutter/engine/assets/919017/fe63808a-6353-4969-8225-120fd5ee0949">

https://github.com/flutter/engine/assets/919017/9284f055-bee1-40cd-8b7e-f478b00d01da

After:
<img width="679" alt="Screenshot 2023-10-05 at 1 24 17 PM" src="https://github.com/flutter/engine/assets/919017/066b1e25-9611-4e14-a383-cc3a866dbe36">

https://github.com/flutter/engine/assets/919017/0fbd1f96-8920-472c-bb0e-4414187fc72d
    @bdero
    bdero authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    1bb228d View commit details
    Browse the repository at this point in the history
Loading