Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 413e95d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e9739bc
Choose a head ref
  • 7 commits
  • 9 files changed
  • 5 contributors

Commits on Apr 14, 2023

  1. Roll Fuchsia Linux SDK from diD1gLr_dKWFJlsSn... to Z0of2S9pf3Zn1nsJP… 

    …... (#41209)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    a74da5d View commit details
    Browse the repository at this point in the history

  2. Run clang tidy builds on arm Macs (#41183) 

    Intel Mac capacity is limited.  Swap the two Mac clang-tidy builders to arm bots.  The clang-tidy linter should run with arm natively.

### Mac Host clang-tidy
Prod x64: https://ci.chromium.org/p/flutter/builders/prod/Mac%20Host%20clang-tidy/3318 Execution 35 mins 2 secs
This PR arm: https://ci.chromium.org/p/flutter/builders/try/Mac%20Host%20clang-tidy/8087 Execution 36 mins 30 secs (this hit an Xcode cache miss which added 4 minutes)

### Mac iOS clang-tidy
Prod x64: https://ci.chromium.org/p/flutter/builders/prod/Mac%20iOS%20clang-tidy/3303 Execution 11 mins 57 secs
This PR arm: https://ci.chromium.org/p/flutter/builders/try/Mac%20iOS%20clang-tidy/8087 Execution 18 mins 10 secs (this hit an Xcode cache miss which added 5 minutes)
    @jmagman
    jmagman authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    69645ed View commit details
    Browse the repository at this point in the history

  3. Remove Mac mac_android_aot_engine in favor of Linux (#41210) 

    `Linux mac_android_aot_engine` is passing: https://ci.chromium.org/p/flutter/builders/try/Linux%20mac_android_aot_engine/1
 
Remove `bringup` and remove `Mac mac_android_aot_engine` in favor of the Linux orchestrator #41181
    @jmagman
    jmagman authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    4a3433f View commit details
    Browse the repository at this point in the history

  4. Revert "[Android] Send connectionClosed message when keyboard becomes… 

    … invisible to ensure framework focus state is correct." (#41211)

Reverts #40746

Googler bug: b/278174021

Failing on

```
shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java:239: Error: This method should only be accessed from tests or within private scope [VisibleForTests]
      imeSyncCallback.remove();
```
    Casey Hillers authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    c2e646d View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 2bd12e31d578 to 22e417bea884 (4 revisions) (#41213) 

    https://skia.googlesource.com/skia.git/+log/2bd12e31d578..22e417bea884

2023-04-14 [email protected] [skottie] Additional guard for SKSL effects
2023-04-14 [email protected] Manual roll Dawn from 27c772262048 to a20c1ee82d29 (13 revisions)
2023-04-14 [email protected] [graphite-dawn] Re-enable tests that no longer fail
2023-04-14 [email protected] Move SkFilterColorProgram class into a separate cpp.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    775343a View commit details
    Browse the repository at this point in the history

  6. [web] Don't run goldctl init more than once (#41207) 

    From the logs reported in flutter/flutter#124864 I noticed we are making multiple calls to `goldctl init` which could be causing some race conditions with the `goldctl imgtest add` calls.

This PR makes sure we only call `goldctl init` once.
    @mdebbar
    mdebbar authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    1ff5495 View commit details
    Browse the repository at this point in the history

  7. [macOS] Build unittests on all macOS host builds (#41215) 

    Whether we're building an x64 or arm64 macOS host build, always build
unit tests.

Issue: flutter/flutter#124840
    @cbracken
    cbracken authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    e9739bc View commit details
    Browse the repository at this point in the history
Loading