Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 394554b
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8c7ce6d
Choose a head ref
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Aug 20, 2023

  1. [Impeller] Fix clip management for DrawPicture. (#44835) 

    Solves two problems:
1. Fix the debug crash by restoring the clip after the `EntityPass`
merge. I initially surrounded the merge with a `Save` and `Restore`,
which was a mistake and is a no-op in this situation. This should have
no excess impact on performance, since we ignore clips in `EntityPass`
when we detect that they won't do anything.
2. Picture subpasses weren't getting their stencil depth adjusted during
the merge, which can result in subpass entities potentially receiving a
clip depth that's too high.
    @bdero
    bdero authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    e4ea62e View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 4f6b9d08b6d1 to d2369dac4a1d (6 revisions) (#44883) 

    https://skia.googlesource.com/skia.git/+log/4f6b9d08b6d1..d2369dac4a1d

2023-08-20 [email protected] Roll vulkan-deps from 86b1009b1e55 to aa121378c102 (1 revision)
2023-08-20 [email protected] Roll vulkan-deps from a8c25b53a106 to 86b1009b1e55 (1 revision)
2023-08-19 [email protected] Roll vulkan-deps from af77dd0a5da0 to a8c25b53a106 (1 revision)
2023-08-19 [email protected] graphite: Implement onReinterpretColorSpace for Image_YUVA
2023-08-18 [email protected] SkQP bash scripts: use python3
2023-08-18 [email protected] Roll vulkan-deps from 2542ba0a2d7e to af77dd0a5da0 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    8c7ce6d View commit details
    Browse the repository at this point in the history
Loading