Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1efe8ba
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d653559
Choose a head ref
  • 3 commits
  • 5 files changed
  • 2 contributors

Commits on Jan 22, 2024

  1. Roll Fuchsia Linux SDK from p0njgljtokVLYfzqK... to uQK4l0QeH_PlZO6cF… 

    …... (#49933)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    992f0bf View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 9cb4de5da15a to cc042f38288e (1 revision) (#49934) 

    https://skia.googlesource.com/skia.git/+log/9cb4de5da15a..cc042f38288e

2024-01-22 [email protected] trim unneeded includes, and hide priv method

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ff6d2c4 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Add golden for Image ColorSource effect transform. (#49930) 

    Adds a golden to verify that Impeller behaves correctly for a variety of
effect transforms, entity (positional) transforms, and source rects.

Skia fiddle: https://fiddle.skia.org/c/6cdc5aefb291fda3833b806ca347a885

Skia (top) vs Impeller (bottom):

![Screenshot 2024-01-22 at 1 37
16 AM](https://github.com/flutter/engine/assets/919017/8b073f83-9821-4004-a56e-60e8946cefe7)
    @bdero
    bdero authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    d653559 View commit details
    Browse the repository at this point in the history
Loading