Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1a6b47a
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f4975e0
Choose a head ref
  • 16 commits
  • 22 files changed
  • 3 contributors

Commits on Sep 5, 2023

  1. Roll Fuchsia Mac SDK from A82pOZ3-NNgfJ2Da7... to qe_q1aYCmE0eC-2Yz... ( 

    #45436)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8bfa414 View commit details
    Browse the repository at this point in the history

  2. Roll ANGLE from ab9bbb9b11b3 to e691a4edb19a (1 revision) (#45437) 

    https://chromium.googlesource.com/angle/angle.git/+log/ab9bbb9b11b3..e691a4edb19a

2023-09-05 [email protected] Delete obsolete VUID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c631e5b View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 8206402f3c35 to 7d0e33e32427 (2 revisions) (#45440) 

    https://skia.googlesource.com/skia.git/+log/8206402f3c35..7d0e33e32427

2023-09-05 [email protected] Roll ANGLE from ebf1e7163216 to e691a4edb19a (3 revisions)
2023-09-05 [email protected] Roll Skia Infra from 959bb251c386 to f5590cb5133d (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3e64f83 View commit details
    Browse the repository at this point in the history

  4. Roll ANGLE from e691a4edb19a to b62216047112 (1 revision) (#45441) 

    https://chromium.googlesource.com/angle/angle.git/+log/e691a4edb19a..b62216047112

2023-09-05 [email protected] Roll Chromium from 97f14c8287da to e89c33139c50 (340 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    91d568c View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 7d0e33e32427 to 9ef0225b5f8a (1 revision) (#45442) 

    https://skia.googlesource.com/skia.git/+log/7d0e33e32427..9ef0225b5f8a

2023-09-05 [email protected] Roll vulkan-deps from 4b7a5f2a3522 to f2f4bb6f20ec (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    476d1c5 View commit details
    Browse the repository at this point in the history

  6. Roll ANGLE from b62216047112 to e72efa276c45 (1 revision) (#45443) 

    https://chromium.googlesource.com/angle/angle.git/+log/b62216047112..e72efa276c45

2023-09-05 [email protected] Roll vulkan-deps from 4b7a5f2a3522 to f2f4bb6f20ec (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    4d3e11d View commit details
    Browse the repository at this point in the history

  7. Roll Skia from 9ef0225b5f8a to 055b26152483 (1 revision) (#45446) 

    https://skia.googlesource.com/skia.git/+log/9ef0225b5f8a..055b26152483

2023-09-05 [email protected] Fix external-texture assertion discovered by the fuzzer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3d88bcb View commit details
    Browse the repository at this point in the history

  8. Roll Fuchsia Mac SDK from qe_q1aYCmE0eC-2Yz... to bHw1LzoikQJthLkTE... ( 

    #45447)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    bf7efe8 View commit details
    Browse the repository at this point in the history

  9. Roll ANGLE from e72efa276c45 to 17c4741d70dd (1 revision) (#45449) 

    https://chromium.googlesource.com/angle/angle.git/+log/e72efa276c45..17c4741d70dd

2023-09-05 [email protected] Metal: Disable blending for masked out attachments

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    80ef03b View commit details
    Browse the repository at this point in the history

  10. Roll Skia from 055b26152483 to d8ea902500a3 (1 revision) (#45448) 

    https://skia.googlesource.com/skia.git/+log/055b26152483..d8ea902500a3

2023-09-05 [email protected] Update DWriteCore to 1.4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0500e75 View commit details
    Browse the repository at this point in the history

  11. Roll ANGLE from 17c4741d70dd to 9666d4d5f7c8 (1 revision) (#45453) 

    https://chromium.googlesource.com/angle/angle.git/+log/17c4741d70dd..9666d4d5f7c8

2023-09-05 [email protected] Disallow dynamic indexing of SecondaryFragData in WebGL 2.0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    987d110 View commit details
    Browse the repository at this point in the history

  12. Adds a Dart library for loading and parsing build configs (#45390) 

    Also adds a test that the build configs in the repo are valid json that
matches the spec.

Fleshed out @christopherfujino's code from here
https://github.com/christopherfujino/flutter-engine-runner/blob/main/main.dart
    @zanderso
    zanderso authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c1a1680 View commit details
    Browse the repository at this point in the history

  13. Roll Skia from d8ea902500a3 to c07fbf4c1d67 (2 revisions) (#45451) 

    https://skia.googlesource.com/skia.git/+log/d8ea902500a3..c07fbf4c1d67

2023-09-05 [email protected] Require a pixel format on all storage textures.
2023-09-05 [email protected] Roll SK Tool from f5590cb5133d to eca28238b5a3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0c0ee03 View commit details
    Browse the repository at this point in the history

  14. [Impeller] compute path bounds once, use Skia computed bounds where p… 

    …ossible. (#45456)

Now that Paths are externally immutable, we can compute the bounds once at construction. This also allows the Skia conversions to set the already computed bounds.
    Jonah Williams authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    7bec262 View commit details
    Browse the repository at this point in the history

  15. Roll ANGLE from 9666d4d5f7c8 to dcd62fc41c3b (1 revision) (#45457) 

    https://chromium.googlesource.com/angle/angle.git/+log/9666d4d5f7c8..dcd62fc41c3b

2023-09-05 [email protected] Trace perf: clear blob cache before each test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    44e12aa View commit details
    Browse the repository at this point in the history

  16. Roll Skia from c07fbf4c1d67 to a0572041af8e (3 revisions) (#45460) 

    https://skia.googlesource.com/skia.git/+log/c07fbf4c1d67..a0572041af8e

2023-09-05 [email protected] Remove SkTime from the public API
2023-09-05 [email protected] [skif] Check dstEnd in loop iteration
2023-09-05 [email protected] Roll FreeType from 2d9fce53 to 45903920 (6 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f4975e0 View commit details
    Browse the repository at this point in the history
Loading