Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0602dbb
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 06dbe28
Choose a head ref
  • 13 commits
  • 19 files changed
  • 6 contributors

Commits on Jun 7, 2019

  1. Roll src/third_party/skia 6e4fee8..3431d9d (17 commits) (#9221) 

    https://skia.googlesource.com/skia.git
/%2Blog/6e4fee8c812e..3431d9d

git log 6e4fee8..3431d9d --date=short --no-merges --format=%ad %ae %s
2019-06-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-06-06 [email protected] Remove duplicate simple samples, make one a gm.
2019-06-06 [email protected] Remove unused caps: UnsignedSupport and ImageLoadStoreSupport
2019-06-06 [email protected] [skottie] Fix text selector sub-unit range handling
2019-06-06 [email protected] Fix line numbering problem when reporting SkSL compile errors
2019-06-05 [email protected] Small fixes to C API. Add SK_API and fix function signature mismatch.
2019-06-06 [email protected] Make FindOrCreateStrikeWithNoDeviceExclusive analog for SkStrikeSpec
2019-06-06 [email protected] Manual revert of "Revise GrDataUtils to be more self-contained"
2019-06-06 [email protected] remove unused metal variable
2019-06-06 [email protected] Revert "Experimental: Add R_16 and RG_1616 to Ganesh"
2019-06-06 [email protected] Remove version from copy shaders.
2019-06-06 [email protected] Rename SkStrikeSpecStorage -> SkStrikeSpec
2019-06-06 [email protected] Move Glyph Intercept code from SkStrike to SkGlyph
2019-06-06 [email protected] Revert "Reland "Remove support for copyAsDraw in gpu copySurface.""
2019-06-06 [email protected] Reland "Fix vulkan async transfer from call to not submit command buffer to early."
2019-06-06 [email protected] Revert "Fix vulkan async transfer from call to not submit command buffer to early."
2019-06-06 [email protected] run rewrite_includes.py

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    2ec6dad View commit details
    Browse the repository at this point in the history

  2. Keyboard support for embedded Android views. (#9203) 

    Generally what this PR is doing is setting up a delegation mechanism
for Android's onCreateInputConnection.

It works by letting the framework know when an embedded view gets loses
focus(within the virtual display), the framework maintains a focus node
for each Android view that is kept in sync with the focus state of the
embedded view.

The TextInputPlugin is extended to allow for 2 type of text clients a
"framework client"(what we had before) and a "platform view client".
When the AndroidView's focus node in the framework is focused the
framework sets a "platform view text client" for the TextInputPlugin,
which will result in the TextInputPlugin delegating
createInputConnection to the platform view.

When a platform view is resized, we are detaching it from a virtual
display and attaching it to a new one, as a side affect a platform view
might lose an active input connection, to workaround that we "lock" the
connection when resizing(by caching it and forcing the cached copy until
the resize is done).

Additional things worth calling out in this PR:

To properly answer which views are allowed for input connection
proxying we compare a candidate view's root view to the set of root
views of all virtual displays.
We also preserve a view's focus state across resizes.
Note that this PR only wires text for the io.flutter.view.FlutterView
For the new Android embedding some additional plumbing is necessary.

Corresponding framework PR: flutter/flutter#33901

flutter/flutter#19718
    @amirh
    amirh authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    e80df36 View commit details
    Browse the repository at this point in the history

  3. Roll src/third_party/skia 3431d9d..0e83626 (2 commits) (#9223) 

    https://skia.googlesource.com/skia.git
/%2Blog/3431d9d1dcc6..0e83626

git log 3431d9d..0e83626 --date=short --no-merges --format=%ad %ae %s
2019-06-07 [email protected] Roll ../src 5f60135c7766..6406ce90edf0 (429 commits)
2019-06-07 [email protected] Roll third_party/externals/swiftshader 5c9e165..c2c829b (4 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    e3b8b61 View commit details
    Browse the repository at this point in the history

  4. Roll src/third_party/skia 0e83626..6faf8d6 (1 commits) (#9225) 

    https://skia.googlesource.com/skia.git
/%2Blog/0e8362655a66..6faf8d6

git log 0e83626..6faf8d6 --date=short --no-merges --format=%ad %ae %s
2019-06-07 [email protected] Roll third_party/externals/angle2 b91f87b..ea49f6f (8 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    9dafb40 View commit details
    Browse the repository at this point in the history

  5. Roll src/third_party/dart 6e0d978..40ef0c6 (7 commits) 

    dart-lang/sdk@40ef0c6d9f Specify type of _location field in Widget Inspector Transformer
dart-lang/sdk@ad38f88c59 [vm/transferable] Skip oom test on mac
dart-lang/sdk@fd77972d8f Print time to prepare linking inputs.
dart-lang/sdk@60f37fa189 Fix builds targeting Android from a Windows host gen_snapshot.
dart-lang/sdk@8c9765c648 Clean up lazy_ast a bit.
dart-lang/sdk@01b0001f8e [vm/transferable] Refactor oom transferable test out of other throwing tests.
dart-lang/sdk@19447e1061 [vm/transferable] Skip oom transferable test on asan.
    @bkonyi
    bkonyi committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    8281919 View commit details
    Browse the repository at this point in the history

  6. Roll src/third_party/skia 6faf8d6..fe18de5 (1 commits) (#9228) 

    https://skia.googlesource.com/skia.git
/%2Blog/6faf8d662af8..fe18de5

git log 6faf8d6..fe18de5 --date=short --no-merges --format=%ad %ae %s
2019-06-06 [email protected] Experimental: Add R_16 and RG_1616 to Ganesh (take 2)

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    91ee780 View commit details
    Browse the repository at this point in the history

  7. Roll src/third_party/dart 40ef0c6..9f2f5ad (4 commits) 

    dart-lang/sdk@9f2f5adb64 Reland [vm/ffi] Regression test for dartbug.com/36993
dart-lang/sdk@15a3df3c10 Migration: add support for cascade expressions.
dart-lang/sdk@da66902e4f Fix a bug in constructor element display string (issue 37165)
dart-lang/sdk@85cadff46b Revert "Fix implementation of isDartCore and isDartAsync."
    @bkonyi
    bkonyi committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    8a6bad6 View commit details
    Browse the repository at this point in the history

  8. move webOnlyScheduleFrameCallback off of window (#9222)

    Jonah Williams authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    086b5a4 View commit details
    Browse the repository at this point in the history

  9. Roll src/third_party/skia fe18de5..14c8ca9 (11 commits) (#9231) 

    https://skia.googlesource.com/skia.git
/%2Blog/fe18de506097..14c8ca9

git log fe18de5..14c8ca9 --date=short --no-merges --format=%ad %ae %s
2019-06-07 [email protected] Build fix
2019-06-07 [email protected] Interpreter: Refactor interface and lifetime management
2019-06-07 [email protected] fold through SKSL_USE_STD_STRING
2019-06-07 [email protected] free skvx from its Skia shackles
2019-06-07 [email protected] Revise GrDataUtils to be more self-contained (take 3)
2019-06-07 [email protected] Reland "Reland "Remove support for copyAsDraw in gpu copySurface.""
2019-06-07 [email protected] Remove advance only mode from SkGlyph.
2019-05-30 [email protected] SkParagraph
2019-06-07 [email protected] Roll skia/third_party/skcms 386ae89d2b64..ed2c978cdeef (1 commits)
2019-06-07 [email protected] Another attempt at a shim to get sk_cf_obj landed.
2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    041c791 View commit details
    Browse the repository at this point in the history

  10. Roll src/third_party/dart 9f2f5ad..6d608fb (5 commits) 

    dart-lang/sdk@6d608fb52b [gen_snapshot] Provide option to generate ELF libraries pre-stripped.
dart-lang/sdk@454758d1e1 [fuchsia] swap out deprecated flag name
dart-lang/sdk@2bba747ae3 Don't attempt to serialize FunctionExpression(s).
dart-lang/sdk@9ff2c109bb [dart:io] Clarify CompressionOptions null window bits means default window.
dart-lang/sdk@8a57c1d463 handle range errors when getting locations
    @bkonyi
    bkonyi committed Jun 7, 2019
    Configuration menu
    Copy the full SHA
    a7fb7da View commit details
    Browse the repository at this point in the history

  11. Add web integration test to build_and_test_host (#9218) 

    This will catch failure early for cases like #9216 (which fixes manual roll for #8983).
    @liyuqian
    liyuqian authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    8eaddd6 View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary whitelisted flags for --dart-flags (#9233)

    @bkonyi
    bkonyi authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    99240b7 View commit details
    Browse the repository at this point in the history

  13. Fix instantiateImageCodec api diff with web (stub) (#9234) 

    Also filed: flutter/flutter#34075
to potentially support on web.

addresses:
https://cirrus-ci.com/task/5192675427352576
    @iskakaushik
    iskakaushik authored Jun 7, 2019
    Configuration menu
    Copy the full SHA
    06dbe28 View commit details
    Browse the repository at this point in the history
Loading