Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f9bc342c84e2
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6db2f3e9857c
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on May 31, 2023

  1. [web] Remove the JS API for url strategy (#42134)

    Finally, we can remove this JS global function for customizing the url strategy.
    
    Why I think we don't need to go through an official deprecation process:
    
    1. It was initially made for internal use in Google3, and right now there are no references to it.
    2. There's no public documentation of this JS function.
    3. External users customize their url strategy through `flutter_web_plugins` which has been [migrated](flutter/flutter#123443) already.
    mdebbar authored May 31, 2023
    Configuration menu
    Copy the full SHA
    c1ef0d9 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Configuration menu
    Copy the full SHA
    8891877 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e83bcf8 View commit details
    Browse the repository at this point in the history
  3. Revert "[web] Remove the JS API for url strategy" (#42468)

    Reverts #42134
    
    This is blocking the engine into framework roller:
    
    See: https://cirrus-ci.com/task/5610586755563520
    
    ```
    Analyzing 3 items...                                            
      error � The class 'UrlStrategy' can't be extended outside of its library because it's an interface class � dev/integration_tests/web_e2e_tests/test_driver/url_strategy_integration.dart:48:31 � invalid_use_of_type_outside_library
    1 issue found. (ran in 321.8s)
      �  �  
      ```
    Jonah Williams authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    6db2f3e View commit details
    Browse the repository at this point in the history
Loading