Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f5ec4ab0bf94
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1572635432c0
Choose a head ref
  • 17 commits
  • 46 files changed
  • 7 contributors

Commits on Jul 23, 2024

  1. [Impeller] Implement OpenGL to Vulkan texture trampolining. (#53966)

    This decouples the Impeller on-by-default effort from the release schedule and [plugin migrations](flutter/flutter#151018).
    
    The plugin migration documented in [go/impeller-plugin-migration][plugin-migration] is still recommended and facilitates zero-copy texture transfers between OpenGL and Vulkan. To recap, the plugin migration is to move away from the OpenGL-only SurfaceTexture APIs in the plugin interface.
    
    This patch facilitates rendering OpenGL textures in a Vulkan renderer using texture trampolining using a single device-device transfer on all devices that support Impeller using the Vulkan renderer.
    
    The performance of this approach is more than acceptable but at the cost of an additional texture allocation and will serve as a fallback to the for any remaining unmigrated plugins (all first-party plugins will already be migrated when the Impeller is on by default and we are following up on the migration of the major third-party plugins as well).
    
    This is a straight improvement to the current state of things were unmigrated plugins will render an empty quad.
    chinmaygarde authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f3b053e View commit details
    Browse the repository at this point in the history
  2. Set the view ID for FlView (#54043)

    Follow up to #54018.
    robert-ancell authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    27673f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b910443 View commit details
    Browse the repository at this point in the history
  4. [DisplayList] track unbounded state on save layers and DisplayLists (#…

    …54032)
    
    New flags on SaveLayerOptions will report if a saveLayer result is unbounded because a rendering operation within its contents did not have a definable bounds and there was no clip installed at the time (consider DrawPaint for example). A similar flag is found on DisplayList objects which reports if their top level had an unbounded operation.
    flar authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    bf5df94 View commit details
    Browse the repository at this point in the history
  5. Roll Skia from 1cda2a7b0ee4 to a9019fddac28 (3 revisions) (#54050)

    skia-flutter-autoroll authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fef21a6 View commit details
    Browse the repository at this point in the history
  6. [Impeller] add emulated advanced blend support for exp canvas. (#54020)

    Refactors flip backdrop into a shared method and adds supported for emulated advanced blends in exp canvas. Last missing feature (AFAIK).
    Jonah Williams authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b1cbf54 View commit details
    Browse the repository at this point in the history
  7. Roll Skia from a9019fddac28 to 2d518b6a793a (4 revisions) (#54052)

    skia-flutter-autoroll authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    919b5e4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e27c8f5 View commit details
    Browse the repository at this point in the history
  9. Roll Skia from 2d518b6a793a to f4355cf73508 (9 revisions) (#54058)

    https://skia.googlesource.com/skia.git/+log/2d518b6a793a..f4355cf73508
    
    2024-07-23 [email protected] Disable path_text_clipped_uncached on Pixel4XL Vulkan configs
    2024-07-23 [email protected] Mark samplers as explicitly-sampled when passing them to a function.
    2024-07-23 [email protected] Revert "[skif] Use src blending when possible"
    2024-07-23 [email protected] Further limit F16 draw test
    2024-07-23 [email protected] Remove use of enable_skslc flag
    2024-07-23 [email protected] Simplify control flow in css_hwb_to_srgb.
    2024-07-23 [email protected] [loong64] Optimize gauss blur imagefilter.
    2024-07-23 [email protected] [SkSL] Change specialization mapping to expression
    2024-07-23 [email protected] [graphite] Fix basic drawShadow functionality.
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    102d21f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6486cbd View commit details
    Browse the repository at this point in the history
  11. [iOS] Mark EmbeddedViewCount const (#54062)

    Since this method isn't mutating the pool, we should mark it const.
    
    Cleanup spotted while working on #54056.
    
    No test because no semantic change. The compiler is the test.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    dbeab2a View commit details
    Browse the repository at this point in the history
  12. [iOS] Flush layer pool after platform view dispose (#54056)

    `FlutterPlatformViewLayerPool` is a pool of iOS layers used for rendering platform views on iOS. When layers are no longer needed, we currently mark them available for re-use but we never actually flush them and thus recover the memory associated with these layers once we know that the layers are no longer needed.
    
    We now flush the layer pool on `SubmitFrame` if a previously-used layer is no longer used in the current frame. In theory, this could cause a performance regression in the case where an additional layer is needed every second or third frame, but we should keep it simple on the first pass and only complicate things later if warranted.
    
    Fixes: flutter/flutter#152053
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e1952a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    c2826c6 View commit details
    Browse the repository at this point in the history
  2. [DisplayList] Fix assertions on DisplayList verbose comparison tests (#…

    …54065)
    
    Fixes 2 problems recently uncovered in the DisplayList verbose comparison test mechanism:
    
    - The verbose compare methods never asserted a test failure, relying on the caller to do so from their return value - but they also did not prompt the caller to check the return value. So a `[[nodiscard]]` is added to remind test writers that they need to assert on the return value
    - As a result of the above, some bad tests were recently added to the tree that were failing but did not assert a test failure. Now that the `[[nodiscard]]` is added, they failed to compile and had to have asserts added.
    
    A secondary problem is that those non-failing tests were inadvertently cherry-picked from a reverted PR that is being reintroduced in incremental sections so as to avoid large scale golden image failures. The tests depend on parts of that PR that haven't been pulled forward yet (but will soon be) so those tests shouldn't have been added in the first place (and were failing, but not causing a gtest failure because of their missing asserts). They remain here, but their results are reversed to indicate the current state of affairs (they assert that the missing functionality isn't in place yet). Their assertions will be reverted when/as the missing functionality is pulled forward in a more incremental (responsible) way.
    flar authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a1278eb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0eb37cc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    880b168 View commit details
    Browse the repository at this point in the history
  5. Change JSArray.length to return int (#54051)

    This is in preparation for
    https://dart-review.googlesource.com/c/sdk/+/373884, which will add length to the extension type itself. This will shadow the extension member, so we should make sure the type signatures match.
    srujzs authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1572635 View commit details
    Browse the repository at this point in the history
Loading