Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f53fbd8393ce
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3fb60b8f37c3
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 8, 2024

  1. [Impeller] blur: drop eighth downsample barrier (#50405) 

    issue: flutter/flutter#142990

I pushed this value as low as I dared to go and ended up with a kernel
size of 41 (radius 20). This means the range of sigma ~60 to ~70 will
now be 1/16th scalar instead of 1/8th.

Here is the new downsample rate versus sigma on a 2x display.

## before
<img width="903" alt="Screenshot 2024-02-06 at 10 28 58 AM"
src="https://github.com/flutter/engine/assets/30870216/f94896d3-fe1c-40e5-8ff4-d50bafbd0b5e">

## after
<img width="901" alt="Screenshot 2024-02-06 at 10 26 49 AM"
src="https://github.com/flutter/engine/assets/30870216/bc5cced7-b8c4-4597-9dd4-c460b966176b">


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @gaaclarke
    gaaclarke authored Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3fb60b8 View commit details
    Browse the repository at this point in the history
Loading