Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f0b718e28779
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8d07c2947e60
Choose a head ref
  • 3 commits
  • 16 files changed
  • 3 contributors

Commits on Sep 7, 2023

  1. Roll Skia from 16df0c27bc0e to c3d6534b0ac3 (3 revisions) (#45543) 

    https://skia.googlesource.com/skia.git/+log/16df0c27bc0e..c3d6534b0ac3

2023-09-07 [email protected] Remove unused file SkOrderedReadBuffer.h
2023-09-07 [email protected] Rename SkBaseDevice to SkDevice
2023-09-07 [email protected] [paragraph] Minor cleanup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    e67ac3c View commit details
    Browse the repository at this point in the history

  2. [fuchsia] Restructure Flatland vsync loop (#45531) 

    This CL restructures Flatland vsync loop to fire for each vsync instead
of each OnNextFrameBegin. As shown in the traces attached to the bug,
the current implementation of firing callbacks on each OnNextFrameBegin
causes skips when Flutter has longer draw calls. By scheduling frames in
between, we are increasing the chance of sending one before the latch
point. OnNextFrameBegin is now used to keep track of present credits and
future presentation times as well as when to start frame, replacing the
need for max_frames_in_flight and vsync_offset fields.

Bug: b/296272449
    @uysalere
    uysalere authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    633ba42 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Document and slightly refactor ResourceManagerVK & frien… 

    …ds. (#45474)

@chinmaygarde specifically, let me know if I violated any correctness you were looking for, or if you would prefer I _don't_ make 1 or more of the changes I made here.

@gaaclarke would love your input on C++ style specifically, or anything that stands out in general.

---

## Summary

I plan to use the resource strategy in flutter/flutter#133198, but wanted to understand the code better first, so this is my contribution to make it a bit easier to understand (hopefully! push back if not!) and contribute tests.

1. Renamed `Reset(ResourceType)` to `Swap()` for consistency with the std smart pointers.
2. Moved non-trivial work out of the constructor into `::Create` ([style guide](https://google.github.io/styleguide/cppguide.html#Doing_Work_in_Constructors)).
3. Added some `FML_DCHECK`s to private APIs to enforce correctness.
4. Made classes final and methods private where they were effectively that ([style guide](https://google.github.io/styleguide/cppguide.html#Inheritance)).
5. Added tests to make sure I understood the contracts.
    @matanlurey
    matanlurey authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    8d07c29 View commit details
    Browse the repository at this point in the history
Loading