Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ecdaed76f284
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 44a0a6ee4d39
Choose a head ref
  • 18 commits
  • 47 files changed
  • 7 contributors

Commits on Jan 11, 2024

  1. Roll Dart SDK from 3245b92a5930 to 7f3ea1c3bc27 (1 revision) (#49710) 

    https://dart.googlesource.com/sdk.git/+log/3245b92a5930..7f3ea1c3bc27

2024-01-11 [email protected] Version 3.4.0-17.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5d7241a View commit details
    Browse the repository at this point in the history

  2. Roll Skia from c46008e5a839 to 2a5710618fc3 (1 revision) (#49712) 

    https://skia.googlesource.com/skia.git/+log/c46008e5a839..2a5710618fc3

2024-01-11 [email protected] Roll vulkan-deps from 16c36d451859 to de550f45d3fe (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    0442dde View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 2a5710618fc3 to 440f5f849008 (1 revision) (#49715) 

    https://skia.googlesource.com/skia.git/+log/2a5710618fc3..440f5f849008

2024-01-11 [email protected] Libgrapheme build to fail when generator fails

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b93d707 View commit details
    Browse the repository at this point in the history

  4. Try to get GLES tests running... (#49701) 

    I plan to fix the GLES fragment program reload issue, but first want to make sure this gets some failures for it.

Added a few skips for shaders that require an extension not available on CI (mipmap related ones).

Updated a couple tests that were failing.
    @dnfield
    dnfield authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    750e7a1 View commit details
    Browse the repository at this point in the history

  5. Roll Dart SDK from 7f3ea1c3bc27 to 6f5bd26b293d (1 revision) (#49720) 

    https://dart.googlesource.com/sdk.git/+log/7f3ea1c3bc27..6f5bd26b293d

2024-01-11 [email protected] Version 3.4.0-18.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b7d360e View commit details
    Browse the repository at this point in the history

  6. [Impeller] Add DrawLine/DrawOval/ClipOval operations to the canvas re… 

    …corder (#49697)
    @jason-simmons
    jason-simmons authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6202fd2 View commit details
    Browse the repository at this point in the history

  7. Osv-scanner integration (#49470) 

    This change integrates directly with osv-scanner rather than using the OSV API to query each dependency for vulnerabilities.

- use [lockfile format](#49203) for third party deps rather than a flat file
- let osv-scanner do the work of checking for vulns rather than API calls to OSV database
- let osv-scanner create and populate the SARIF results 

A successful run of the vulnerability scanner can be seen in the tests of this PR.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @sealesj
    sealesj authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    61e72c3 View commit details
    Browse the repository at this point in the history

  8. Roll Skia from 440f5f849008 to 56f28f137507 (1 revision) (#49723) 

    https://skia.googlesource.com/skia.git/+log/440f5f849008..56f28f137507

2024-01-11 [email protected] [graphite] Don't call wgpu::ShaderModule::GetCompilationInfo on emsdk < 3.1.51

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    cc5d481 View commit details
    Browse the repository at this point in the history

  9. Google GitHub mirrors - reland (#49716) 

    Reland of #49203 after permissions issue. The googleapis.dart mirror is now verified to be publicly available.

Also remove github dependency variable since there are no more existing uses.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @sealesj
    sealesj authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e7e9c1a View commit details
    Browse the repository at this point in the history

  10. Roll Fuchsia Linux SDK from gJuGKaWsKazIrvQeO... to Klxww53tA4-TG5pA9… 

    …... (#49730)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    c88c6ec View commit details
    Browse the repository at this point in the history

  11. Revert Dart SDK to 3245b92a5930 (#49727) 

    A recent Dart SDK roll included a regression affecting runs of "flutter analyze" on individual files

(see https://dart.googlesource.com/sdk/+/89bd370e95c0695250a4f0111be3134b9936eadd)
    @jason-simmons
    jason-simmons authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    569a2b1 View commit details
    Browse the repository at this point in the history

  12. Roll Skia from 56f28f137507 to b63e5a3c14e1 (1 revision) (#49733) 

    https://skia.googlesource.com/skia.git/+log/56f28f137507..b63e5a3c14e1

2024-01-11 [email protected] Add placeholder files for Graphite ES2 support.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    f7cf731 View commit details
    Browse the repository at this point in the history

  13. [Impeller] dont accidentally copy shared ptr. (#49731) 

    Copying the shared ptr when we don't need to results in us incrementing/decrementing the ref count which isn't free.
    Jonah Williams authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6db71f2 View commit details
    Browse the repository at this point in the history

  14. Run tests on macOS 13 only (#49722) 

    Release team wants engine tests running exclusively on macOS 13 in main for a while before CP'ing to beta.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @vashworth
    vashworth authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    74fcc38 View commit details
    Browse the repository at this point in the history

  15. [Impeller] Begin migrating to RenderPass command recording API. (#49480) 

    Part of flutter/flutter#140804 proposes removing the Command object. This demonstrates the new API without changing the implementation, which can be done separately per backend. This also doesn't change every single callsite for reasons...
    Jonah Williams authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    cded76e View commit details
    Browse the repository at this point in the history

  16. Roll Skia from b63e5a3c14e1 to d65d18ac1e8d (1 revision) (#49735) 

    https://skia.googlesource.com/skia.git/+log/b63e5a3c14e1..d65d18ac1e8d

2024-01-11 [email protected] Add support for SkSL Graphite ES2 program kinds.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    0e6e7d8 View commit details
    Browse the repository at this point in the history

  17. Add SurfaceTextureSurfaceProducer (#49653) 

    Unblocks flutter/flutter#139702.

The next step will be local validation that this API works for at least a few of our internal plugins (video_player, camera).
    @matanlurey
    matanlurey authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    42738dd View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Roll Skia from d65d18ac1e8d to e9de42588e54 (1 revision) (#49738) 

    https://skia.googlesource.com/skia.git/+log/d65d18ac1e8d..e9de42588e54

2024-01-12 [email protected] Roll vulkan-deps from de550f45d3fe to 3cfac285a67f (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    44a0a6e View commit details
    Browse the repository at this point in the history
Loading