-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: ecbb2b28d48a
head repository: flutter/engine
compare: a5215ce5000a
- 9 commits
- 22 files changed
- 4 contributors
Commits on Aug 4, 2018
-
Roll src/third_party/skia 4c3b63e..71fe8ba (3 commits) (#5940)
Auto-roller completed checks. Merging.
Configuration menu - View commit details
-
Copy full SHA for aaf4a9a - Browse repository at this point
Copy the full SHA aaf4a9aView commit details -
Roll src/third_party/skia 71fe8ba..59aabbc (1 commits) (#5942)
Auto-roller completed checks. Merging.
Configuration menu - View commit details
-
Copy full SHA for 97aea09 - Browse repository at this point
Copy the full SHA 97aea09View commit details
Commits on Aug 5, 2018
-
Roll src/third_party/skia 59aabbc..2e77f54 (1 commits) (#5943)
Auto-roller completed checks. Merging.
Configuration menu - View commit details
-
Copy full SHA for 63ede2e - Browse repository at this point
Copy the full SHA 63ede2eView commit details
Commits on Aug 6, 2018
-
Replace acquire+release thread annotation with excludes (#5944)
The behavior of acquire+release annotation handling has changed in https://reviews.llvm.org/D49355 which breaks the build with the new Clang. However, as has been pointed out, the acquire+release isn't the right way to prevent double locking as the annotations negate each other; the correct way is to use excludes or negative requires. Using excludes annotations also requires using std::lock_guard instead of std::unique_lock because the latter doesn't have the thread annotations due to deferred locking which is not needed in Flutter and so std::lock_guard is a sufficient alternative.
Configuration menu - View commit details
-
Copy full SHA for c6baaaf - Browse repository at this point
Copy the full SHA c6baaafView commit details -
Roll src/third_party/skia 2e77f54..12fb9cf (1 commits) (#5945)
Auto-roller completed checks. Merging.
Configuration menu - View commit details
-
Copy full SHA for f4464a8 - Browse repository at this point
Copy the full SHA f4464a8View commit details -
Roll src/third_party/skia 12fb9cf..6e487e6 (8 commits) (#5946)
Auto-roller completed checks. Merging.
Configuration menu - View commit details
-
Copy full SHA for 5770cbd - Browse repository at this point
Copy the full SHA 5770cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc885f3 - Browse repository at this point
Copy the full SHA bc885f3View commit details -
Roll src/third_party/skia 6e487e6..641ac7d (16 commits) (#5948)
Auto-roller completed checks. Merging.
Configuration menu - View commit details
-
Copy full SHA for 4681351 - Browse repository at this point
Copy the full SHA 4681351View commit details -
Add hasImplicitScrolling SemanticFlag and support in Android bridge (#…
Jonah Williams authoredAug 6, 2018 Configuration menu - View commit details
-
Copy full SHA for a5215ce - Browse repository at this point
Copy the full SHA a5215ceView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff ecbb2b28d48a...a5215ce5000a