Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eba6dba14c69
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d4d2afd04186
Choose a head ref
  • 3 commits
  • 11 files changed
  • 3 contributors

Commits on May 5, 2022

  1. Fix gtk targets for arm64 artifacts. (#33130)

    @godofredoc
    godofredoc authored May 5, 2022
    Configuration menu
    Copy the full SHA
    88b3974 View commit details
    Browse the repository at this point in the history

  2. Set Platform.executable on startup (#33127) 

    Previously, using Platform.executable (from dart:io) returned null (if
non-null-by-default was disabled) or threw an exception (if NNBD was
enabled) since we weren't setting it.

We now pass the executable name to Dart during VM startup based on the
first value in the FlutterProjectArgs::command_line_argv array passed to
FlutterEngineRun (or FlutterEngineInitialize) on startup. argv[0] (if
specified) is explicitly documented as being required to be the
executable name in embedder.h. In the case where no argv[0] is
specified, we instead set Platform.executable to "Flutter" in order to
avoid violating the (non-nullable) type annotation on
Platform.executable.

Note that dart::bin::SetExecutableName() does NOT make a copy of the
input string, so that value needs to be available for the entire lifetime
of the VM.

This also adds EmbedderConfigBuilder::SetExecutableName() to support
setting a fake executable name in unittests. By default, we continue to
set the name "embedder_unittest" unless overridden using this method.

See: https://api.flutter.dev/flutter/dart-io/Platform/executable.html
See: dart-lang/sdk#48427

Issue: flutter/flutter#83921
    @cbracken
    cbracken authored May 5, 2022
    Configuration menu
    Copy the full SHA
    ea5839b View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 33cedc38f26d to d7ddbe668dc4 (2 revisions) (#33135)

    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 5, 2022
    Configuration menu
    Copy the full SHA
    d4d2afd View commit details
    Browse the repository at this point in the history
Loading