Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eb89b9440520
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ca30d7df7105
Choose a head ref
  • 4 commits
  • 24 files changed
  • 3 contributors

Commits on Nov 9, 2023

  1. Use specific version of mac_toolchain (#47835) 

    Newer versions of mac_toolchain increase Xcode install times by ~2 minutes (flutter/flutter#138109). As a temporary solution, we're using an older version of mac_toolchain.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @vashworth
    vashworth authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    bfe3f10 View commit details
    Browse the repository at this point in the history

  2. Roll Dart SDK from 6bd98dc2dffd to 33307e78db2b (1 revision) (#47865) 

    https://dart.googlesource.com/sdk.git/+log/6bd98dc2dffd..33307e78db2b

2023-11-09 [email protected] Version 3.3.0-113.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    145785a View commit details
    Browse the repository at this point in the history

  3. [Re-land] Upgrade Android SDK to 34 "UpsideDownCake" (#47839) 

    The difference between this PR and the original is the change to the `AndroidManifest.xml`. For context, right before the original PR landed, [a change to upgrade the target sdk](#47683) in the manifest from 31 to 33 landed. It also removed the lint complaining about using an old target sdk version from the baseline lint file. So this change upgrading the sdk, but not the target sdk in the manifest, triggered the lint again.

For the rest of the PR, [see the description of the original PR](#47609).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gmackall
    gmackall authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f2c6b50 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 775da2d297de to a58076ed871a (3 revisions) (#47866) 

    https://skia.googlesource.com/skia.git/+log/775da2d297de..a58076ed871a

2023-11-09 [email protected] Manual roll Dawn from 46e9e4cbfdfc to 3ec333906a35 (4 revisions)
2023-11-09 [email protected] [graphite] Use kFibonacci GrowthPolicy in more SkTBlockLists
2023-11-09 [email protected] Fix MacOS features check.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ca30d7d View commit details
    Browse the repository at this point in the history
Loading