Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e5e06c97c33c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a3741d6248b7
Choose a head ref
  • 14 commits
  • 45 files changed
  • 6 contributors

Commits on Nov 5, 2024

  1. Roll Fuchsia Linux SDK from amgHXcqtplha8LuI_... to z1otZzn3yKuGnu1st… 

    …... (#56374)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    918736c View commit details
    Browse the repository at this point in the history

  2. iOS: Refactor ShellTestPlatformViewMetal (#56370) 

    Migrates DarwinContextMetal to a plain C struct, eliminating the need for constructor, getters, etc. since it's only used in this translation unit. The fields themselves cannot be inlined as fields on ShellTestPlatformViewMetal because the header in which that class is defined is included in plain C++ (non-Obj-C++) translation units and therefore cannot contain Obj-C types.

This simplifies the code and simultaneously fixes complicated ARC behaviour in which the const "DarwinContextMetal::context()" getter caused retainCount to be incremented on the underlying context_ pointer, but not decremented even if never unassigned. In particular the line
```objc
FML_CHECK([metal_context->context() mainContext]));
```
appeared to cause refcount to be incremented but never decremented.

Regardless of the ARC issue, this significantly simplifies the code.

This also eliminates the last remaining use of fml::scoped_nsobject in Flutter's codebase. That class will be removed in a followup PR.

No test changes since there is no change to semantics.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0342d1d View commit details
    Browse the repository at this point in the history

  3. [Impeller] match Skia's old VMA default block size. (#56368) 

    The unspecified default is 256 MiB which is ... big. 4Mb value is the default that Skia used to use, and results in less memory usage at least in local testing.

benchmarks will determine if this has a positive or negative impact on performance.

flutter/flutter#157497
    Jonah Williams authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a13a492 View commit details
    Browse the repository at this point in the history

  4. Roll Dart SDK from b39c729740eb to 3e840340c412 (1 revision) (#56377) 

    https://dart.googlesource.com/sdk.git/+log/b39c729740eb..3e840340c412

2024-11-05 [email protected] Version 3.7.0-104.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e89eefc View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 7989f782dbf4 to b3be9cb59fe8 (6 revisions) (#56380) 

    https://skia.googlesource.com/skia.git/+log/7989f782dbf4..b3be9cb59fe8

2024-11-05 [email protected] Manual roll Dawn from 46043c56bc31 to 08b478b3f3a3 (9 revisions)
2024-11-05 [email protected] Add size tracking to GPU StrikeCache.
2024-11-05 [email protected] Roll vulkan-deps from f4673df701a0 to 97c315f09386 (8 revisions)
2024-11-05 [email protected] Roll Dawn from 2c4f822f9e78 to 46043c56bc31 (12 revisions)
2024-11-05 [email protected] Roll ANGLE from 7ce8b268f584 to 84a24a1ea6a6 (6 revisions)
2024-11-04 [email protected] Roll vulkan-deps from ae5ea7b95745 to f4673df701a0 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    2a89d7b View commit details
    Browse the repository at this point in the history

  6. [Impeller] exploit content context options' perfect hash function. (#… 

    …56360)

The content context options hash function is pefect - meaning a distinct hash guarantees a distinct value and vice versa. We can replace the hashing entirely with an equality check of the hash function.

Additionally, we can remove the hashmap. As most of these maps have fewer than a dozen entries (often just 2 or 3) and the linear search is much faster.
    Jonah Williams authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    dfa70d7 View commit details
    Browse the repository at this point in the history

  7. [web] Switch all fonts to WOFF2 (non-split) (#56035) 

    Google Fonts serves TTF fonts gzipped. By switching to WOFF2 fonts, we get Brotli compression by design.

Google Font's WOFF2 fonts are 30%+ smaller than their gzipped TTF counterparts (including Roboto).
    @mdebbar
    mdebbar authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e553cd6 View commit details
    Browse the repository at this point in the history

  8. [Impeller] Delete any remaining GL objects during destruction of the … 

    …ReactorGLES (#56361)

At shutdown time the ReactorGLES may still be holding handles of GL objects.  These objects should be cleaned up when the reactor is deleted.

This leak can be seen by running DlGoldenTest.ShimmerTest, which takes a series of screenshots.  Each screenshot creates an AiksContext. Without this change, the textures in the AiksContext's ReactorGLES will be leaked after the AiksContext is destroyed.
    @jason-simmons
    jason-simmons authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e8c4840 View commit details
    Browse the repository at this point in the history

  9. Roll Skia from b3be9cb59fe8 to 82175b411c80 (2 revisions) (#56383) 

    https://skia.googlesource.com/skia.git/+log/b3be9cb59fe8..82175b411c80

2024-11-05 [email protected] [Graphite] Fix layout transition for DstCopy in Vulkan.
2024-11-05 [email protected] Update GPU StrikeCache to track Glyph memory as well.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    80d3453 View commit details
    Browse the repository at this point in the history

  10. fml: delete scoped_nsobject.h,mm (#56382) 

    fml::scoped_nsobject and fml::scoped_nsprotocol classes are no longer
necessary now that the entire codebase has been migrated to ARC.

This also eliminates the fml_arc_unittests target which tests that code.
All references to that target in documentation, run_tests.py have been
removed. This target was used in various `et` build/query unit tests and
has been replaced with the fml_unittests target in those cases.

Issue: flutter/flutter#137801
    @cbracken
    cbracken authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    571fac4 View commit details
    Browse the repository at this point in the history

  11. Remove FlScrollingViewDelegate (#56270) 

    We can just contact the engine directly and test that by overriding the
engine API.
    @robert-ancell
    robert-ancell authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    f32b77b View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary method for getting engine switches (command line). (… 

    …#56265)

This method simply wrapped a common method, which is simpler to use
directly. The test only tested this common method, which already has
tests in common/.
    @robert-ancell
    robert-ancell authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ab9b354 View commit details
    Browse the repository at this point in the history

  13. iOS: Use standard Obj-C cflags for ios_test_flutter (#56384) 

    Previously, we had not enabled standard iOS cflags for `ios_test_flutter`, though ARC had been manually added to the cflags. This meant that the following flags were not enabled:

* -Werror=overriding-method-mismatch
* -Werror=undeclared-selector

Both of these existed in the code within this target:

* undeclared-selector: `insertionPointColor` was a non-public selector on UITextInput prior to iOS 17.
* overriding-method-mismatch: `FakeFlutterUndoManagerDelegate`, which implements the `FlutterUndoManagerDelegate` protocol, declared `initWithUndoManager:activeInputView:` with a different type for `activeInputView`. This was a hack to jam in a test mock object that didn't match the required type for the property. Conveniently we have a class (`FlutterTextInputView`) that implements the required type and protocol (`UIView<UITextInput>`).

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    758f705 View commit details
    Browse the repository at this point in the history

  14. Increase timeouts for Linux Fuchsia and Linux Web Framework Tests bui… 

    …lders (#56387)

These builders have recently been timing out due to LUCI scheduling delays.
    @jason-simmons
    jason-simmons authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a3741d6 View commit details
    Browse the repository at this point in the history
Loading