Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e1b265bb52aa
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1b132e44194d
Choose a head ref
  • 8 commits
  • 43 files changed
  • 6 contributors

Commits on Feb 3, 2023

  1. [Impeller] Append to existing atlas if room exists, reuse texture (#3… 

    …8253)

* [impeller][wip] append to existing atlas if room exists

* cleanups and reuse texture

* ++

* ++

* ++

* ++

* dnfield review

* ++

* ++

* ++
    Jonah Williams authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    2ddbff9 View commit details
    Browse the repository at this point in the history

  2. [fuchsia] fdio_service_connect no longer provides rights which we need ( 

    #39374)

fdio_service_connect no longer provides rights. Since we need the READABLE right when opening the debug/ctrl/diagnostics directories, this change uses fdio_open_at.

This change also fixes the Clone to remove specific rights and instead use CLONE_SAME_RIGHTS.

Verified locally that we no longer get ACCESS_DENIED on the diagnostics directory when opening in component manager.
    @miguelfrde
    miguelfrde authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9dd2e9c View commit details
    Browse the repository at this point in the history

  3. [impeller] drawVertices blend mode (#38985) 

    * [impeller] drawVertices blend mode

* Squashed commit of the following:

commit fd230d2
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 18 19:07:33 2023 -0800

    fix opacity for pipeline blends

commit 53a2189
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 18 15:32:16 2023 -0800

    Use sub-contents

commit e83fb61
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 18 12:05:53 2023 -0800

    blending cleanup

commit 040a83f
Author: jonahwilliams <[email protected]>
Date:   Tue Jan 17 18:22:47 2023 -0800

    remove atlas_fill from licenses

commit 7d9e751
Author: jonahwilliams <[email protected]>
Date:   Tue Jan 17 17:16:37 2023 -0800

    ++

commit a4f25cd
Author: jonahwilliams <[email protected]>
Date:   Tue Jan 17 17:11:14 2023 -0800

    ++

commit d8b3023
Author: jonahwilliams <[email protected]>
Date:   Tue Jan 17 17:06:53 2023 -0800

    ++

commit 997bb3f
Author: jonahwilliams <[email protected]>
Date:   Tue Jan 17 17:06:23 2023 -0800

    back out vertices change

commit 9dbe177
Merge: 94e6c24 5932bad
Author: jonahwilliams <[email protected]>
Date:   Tue Jan 17 11:19:08 2023 -0800

    Merge branch 'master' of github.com:flutter/engine into drawAtlas

commit 94e6c24
Author: jonahwilliams <[email protected]>
Date:   Fri Jan 13 13:37:33 2023 -0800

    Delete color blending

commit 426d6a1
Author: jonahwilliams <[email protected]>
Date:   Thu Jan 12 16:59:00 2023 -0800

    ++

commit 3905cb1
Author: jonahwilliams <[email protected]>
Date:   Thu Jan 12 16:45:50 2023 -0800

    ++

commit ca273f4
Author: jonahwilliams <[email protected]>
Date:   Thu Jan 12 16:35:40 2023 -0800

    ++

commit a3a9476
Author: jonahwilliams <[email protected]>
Date:   Thu Jan 12 16:35:02 2023 -0800

    basic texture coordiantes work

commit 785e18b
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 11 20:13:56 2023 -0800

    ++

commit 79c13e5
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 11 20:05:10 2023 -0800

    some texture coordinates work

commit 2a27640
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 11 17:59:49 2023 -0800

    CI cleanups

commit 0c23ff4
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 11 16:59:11 2023 -0800

    dont double divide

commit 1a00d10
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 11 12:39:11 2023 -0800

    test fixes

commit 8a1caa1
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 11 11:58:23 2023 -0800

    ++

commit 683e306
Author: jonahwilliams <[email protected]>
Date:   Wed Jan 11 11:57:54 2023 -0800

    add drawVertices uage

commit 56bf47d
Author: jonahwilliams <[email protected]>
Date:   Tue Jan 10 19:12:42 2023 -0800

    ++

commit b2cc708
Merge: ff6f4de 53bd4bb
Author: jonahwilliams <[email protected]>
Date:   Tue Jan 10 16:58:52 2023 -0800

    Merge branch 'master' of github.com:flutter/engine into drawAtlas

commit ff6f4de
Author: jonahwilliams <[email protected]>
Date:   Thu Dec 15 14:38:11 2022 -0800

    fill out drawAtlas

* update to use contents

* ++

* ++

* ++

* ++

* add playground test

* ++

* ++

* ++
    Jonah Williams authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    9dde156 View commit details
    Browse the repository at this point in the history

  4. [ios] Lock refresh rate to 80fps when threads are merged (#39172) 

    When there are PlatformViews on the screen (threads merged), Flutter engine cannot consistently hit 120 fps, especially when the PlatformView is animating (scrolling etc), thus producing janks.
This PR locks the refresh rate to 80fps to avoid janks.

Fixes flutter/flutter#116640
    Chris Yang authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    18750d2 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 83a3d8b16c94 to f083b79aa388 (5 revisions) (#39376) 

    https://skia.googlesource.com/skia.git/+log/83a3d8b16c94..f083b79aa388

2023-02-03 [email protected] Fall back to SkVM for debug traces.
2023-02-03 [email protected] Add GN option to enable shader dumps.
2023-02-03 [email protected] Remove SPIR-V division-by-literal optimization.
2023-02-03 [email protected] Simplify division by a constant.
2023-02-03 [email protected] Zero d registers before bilinear/bicubic rather than in seed_shader

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    fe259c2 View commit details
    Browse the repository at this point in the history

  6. [Impeller] Retain embolden/skew font properties when rendering text g… 

    …lyphs (#39378)
    @bdero
    bdero authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4fdbb0a View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Roll Dart SDK from b7a0c75d4470 to de912d108ebb (1 revision) (#39379) 

    https://dart.googlesource.com/sdk.git/+log/b7a0c75d4470..de912d108ebb

2023-02-03 [email protected] Version 3.0.0-202.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 4, 2023
    Configuration menu
    Copy the full SHA
    868234d View commit details
    Browse the repository at this point in the history

  2. [iOS] Ensure FlutterView's background color is not nil to avoid CAMet… 

    …alLayer nextDrawable being time-consuming (#39359)

* ++

* Add tests

* ++
    @luckysmg
    luckysmg authored Feb 4, 2023
    Configuration menu
    Copy the full SHA
    1b132e4 View commit details
    Browse the repository at this point in the history
Loading