Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e010f17eeb10
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c38272b5e036
Choose a head ref
  • 4 commits
  • 10 files changed
  • 4 contributors

Commits on Nov 17, 2023

  1. [Android] Send " did gain focus" message from engine to framework (#4…

    …7114)
    
    issue:flutter/flutter#97747
    
    framework pr:flutter/flutter#135771
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I signed the [CLA].
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    
    ---------
    
    Co-authored-by: Reid Baker <[email protected]>
    hannah-hyj and reidbaker authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    714987f View commit details
    Browse the repository at this point in the history
  2. Roll Skia from dd7a26ead897 to 04b0ac194443 (8 revisions) (#48186)

    https://skia.googlesource.com/skia.git/+log/dd7a26ead897..04b0ac194443
    
    2023-11-17 [email protected] [bazel] Generate device-specific configurations with Gold/Perf trace keys.
    2023-11-17 [email protected] SkScan_AAAPath: for potential -fsanitize=alignment failure
    2023-11-17 [email protected] Revert "Turn on SK_DISABLE_LEGACY_FONTMGR_FACTORY"
    2023-11-17 [email protected] [docs] Fix /dev/contrib/ links
    2023-11-17 [email protected] Turn on SK_DISABLE_LEGACY_FONTMGR_FACTORY
    2023-11-17 [email protected] Revert "Emoji font resolution fix"
    2023-11-17 [email protected] Touch the skcms files to avoid 409 error on roll
    2023-11-17 [email protected] Roll SK Tool from bc5a26ce9f2b to ff8a5b05fd8b
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    5abad05 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a0aecf8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c38272b View commit details
    Browse the repository at this point in the history
Loading