Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: db6da000a17e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 046ec85dffc6
Choose a head ref
  • 5 commits
  • 6 files changed
  • 4 contributors

Commits on Nov 13, 2023

  1. Add a libcxxabi module that provides support for C++ thread-local sto… 

    …rage (#47886)

See flutter/flutter#138117
    @jason-simmons
    jason-simmons authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    262a714 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 17b6555a1551 to 1a39bd56cda2 (2 revisions) (#47980) 

    https://skia.googlesource.com/skia.git/+log/17b6555a1551..1a39bd56cda2

2023-11-13 [email protected] Update GrBufferAllocPool pushBack to not loop over or destroy blocks.
2023-11-13 [email protected] Graphite: Support Plane2 and NV12A

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    0e3a62e View commit details
    Browse the repository at this point in the history

  3. [web] - fix Safari textfield selection bug (#47917) 

    In order to fix Safari autofill, we've had to give inactive elements non-zero size because Safari does not respect offscreen or 0-sized inputs, and this leads to broken autofill behavior (see: #43058).

As part of these changes, we needed to disable pointer events for the parent `<form>` element so that we don't have pointer event collisions if users hover over or click into the invisible autofill elements within that form.

This led to an issue where offsets weren't being calculated correctly for "active" inputs because they relied on pointer events bubbling up and being caught by the form.  The fix is to explicitly set pointer events on the active inputs, so that we can correctly discern when our pointer event target is actually the input and correctly calculate the offsets.

Fixes flutter/flutter#136006
    @htoor3
    htoor3 authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    6b2de88 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 1a39bd56cda2 to 9ac5cad143ec (3 revisions) (#47984) 

    https://skia.googlesource.com/skia.git/+log/1a39bd56cda2..9ac5cad143ec

2023-11-13 [email protected] Reland "Add use of sk_ieee_float_divide to init_stop_pos."
2023-11-13 [email protected] Add GraphiteVkTestHelper
2023-11-13 [email protected] Manual roll ANGLE from f773a79fef38 to 1819b4495440 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    11b80d6 View commit details
    Browse the repository at this point in the history

  5. Fix fuchsia upload symbols. (#47938) 

    The fuchsia bucket does not have a delete ACL which is required to replace files that already exist. This change skips uploading the file if it already exists.

Bug: flutter/flutter#126461
Bug: flutter/flutter#135189

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    046ec85 View commit details
    Browse the repository at this point in the history
Loading