Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d46933e6772e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b27e1b38375b
Choose a head ref
  • 9 commits
  • 57 files changed
  • 7 contributors

Commits on Oct 20, 2023

  1. Roll Skia from de628929015d to b960e9140f56 (2 revisions) (#47164) 

    https://skia.googlesource.com/skia.git/+log/de628929015d..b960e9140f56

2023-10-20 [email protected] Add Graphite Vello Test jobs to CQ
2023-10-20 [email protected] Add point_less_than_segment_in_x

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8aee4dd View commit details
    Browse the repository at this point in the history

  2. [Impeller] GPU Tracer for GLES. (#47080) 

    Trace GPU execution time on GLES using GL_EXT_disjoint_timer_query. This requires a per-app opt in from the Android Manifest with the key `"io.flutter.embedding.android.EnableOpenGLGPUTracing` set to true.
    Jonah Williams authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    29168dd View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from ba96a157a8eb to 53fee35b299f (1 revision) (#47165) 

    https://dart.googlesource.com/sdk.git/+log/ba96a157a8eb..53fee35b299f

2023-10-20 [email protected] Version 3.3.0-48.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    677d1ce View commit details
    Browse the repository at this point in the history

  4. [macOS] Eliminate extraneous loadView calls (#47166) 

    Eliminate unnecessary calls to [NSViewController loadView]. To quote the [documentation][loadview] for this method: "Do not call this method. If you require this method to be called, access the view property."

In several of the existing tests, we do read viewController.view, and the other tests pass without this line regardless.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    98d3111 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from b960e9140f56 to 9ffd5ef9a9ed (3 revisions) (#47167) 

    https://skia.googlesource.com/skia.git/+log/b960e9140f56..9ffd5ef9a9ed

2023-10-20 [email protected] GraphiteDawn: don't set active render encoder if BlitWithDraw fails.
2023-10-20 [email protected] [graphite] Make RecorderOptions::kDefaultRecorderBudget a static member
2023-10-20 [email protected] Remove staging flag SK_IMPROVE_RASTER_PIPELINE_PRECISION.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    00ff2c9 View commit details
    Browse the repository at this point in the history

  6. Add option to save Impeller failure images in rendertests (#47142) 

    The rendering tests currently always save the impeller failure images into a temporary directory in /tmp which is out of the way and might accumulate over time.

The images are now only saved when `--save-impeller-failures` is specified on the command line and they are now saved into a local sub-directory with multiple runs saving into new sub-directories to keep the failure images from getting confused with each other over time. The new image directories are named `./impeller_failure_images/NNNN/*.png`
    @flar
    flar authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b385c01 View commit details
    Browse the repository at this point in the history

  7. Fix async image loading issues in skwasm. (#47117) 

    This fixes flutter/flutter#134045

There were a few different issues here:
* We need to do our own message passing for rendering pictures. The async methods provided by emscripten have their own queue that can drain synchronously, so basically it's not guaranteed to be FIFO with other messages sent to the web worker or main thread.
* When we drop frames, we should only drop intermediate frames, so that when the rendering flurry stops that the frame that is displayed is the last one that was actually requested.
* We need to reset the GL context after lazy image creation, otherwise skia's renderer gets into a bad state for that frame.
    @eyebrowsoffire
    eyebrowsoffire authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8bd8294 View commit details
    Browse the repository at this point in the history

  8. [web] Support flutterViewId in platform view messages (#46891) 

    - Accept a new `flutterViewId` field in platform view messages.
- Keep transitory support for legacy platform view messages that don't contain `flutterViewId`.
- Default view factories set `width:100%` and `height:100%`.
    @mdebbar
    mdebbar authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    471fbc5 View commit details
    Browse the repository at this point in the history

  9. Add link support in web accessibility (#46117) 

    fixes flutter/flutter#134795

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @chunhtai
    chunhtai authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b27e1b3 View commit details
    Browse the repository at this point in the history
Loading