Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d3dbd4225e08
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: df6b15d35703
Choose a head ref
  • 6 commits
  • 62 files changed
  • 5 contributors

Commits on Jan 22, 2024

  1. Roll Skia from fa5f2461554f to 58973cca0edd (2 revisions) (#49947) 

    https://skia.googlesource.com/skia.git/+log/fa5f2461554f..58973cca0edd

2024-01-22 [email protected] Manual roll ANGLE from 151c1571989e to c6fbf93decba (6 revisions)
2024-01-22 [email protected] Reland "Reland "Add GCC support to Raster Pipeline""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    756686d View commit details
    Browse the repository at this point in the history

  2. [Windows] Rename and move EGL types (#49900) 

    This is a refactoring with no semantic changes. The following types were renamed:

* `flutter::AngleSurfaceManager` to `flutter::egl::Manager`. In subsequent pull requests, this type will _create_ but not _own_ surfaces. Furthermore, this type will be split up to introduce `flutter::egl::Surface` and `flutter::egl::Context`. The manager will own the contexts and each surface will be owned by its view.
* `flutter::GlProcTable` to `flutter::egl::ProcTable`

This also introduces an `egl` directory to the Windows embedder.

Previous pull request: #49895

Part of flutter/flutter#141996

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @loic-sharma
    loic-sharma authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5187843 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Create the golden test screenshotter after setting the Vul… 

    …kan ICD environment variable (#49948)

This ensures that the test process will load the SwiftShader implementation of Vulkan if a VulkanScreenshotter is instantiated.
    @jason-simmons
    jason-simmons authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    a36f78e View commit details
    Browse the repository at this point in the history

  4. [Impeller] remove frame counter that was unused in Vulkan allocator. (#… 

    …49913)

This was from a previous attempt to reduce allocation pressure using per-thread pools, but they don't actually work since as soon as a pool needs to allocate a new block we end up locking on some vk device calls,
    Jonah Williams authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1f01f63 View commit details
    Browse the repository at this point in the history

  5. [Impeller] fixed colorspace for metal screenshots (#49941) 

    fixes flutter/flutter#141903

The golden tests were generating images in the wrong colorspace which
left things brighter than they should have been. This fixes that issue.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @gaaclarke
    gaaclarke authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    cc52c56 View commit details
    Browse the repository at this point in the history

  6. [Impeller] dont emulate command buffers for compute on Metal/Vulkan. (#… 

    …49922)

Part of the work for: flutter/flutter#140804

Removes ComputeCommand and has both ComputePassMTL and ComputePassVK immediately record to their respective comand buffers. This combines the commits for Metal/Vulkan as they are both fairly small. After this, I can add barriers to fix compute for Vulkan.
    Jonah Williams authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    df6b15d View commit details
    Browse the repository at this point in the history
Loading