Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d0d6a4c2362d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0dc86cda19d5
Choose a head ref
  • 9 commits
  • 13 files changed
  • 7 contributors

Commits on Jul 7, 2020

  1. Configuration menu
    Copy the full SHA
    a53782f View commit details
    Browse the repository at this point in the history
  2. kick build (#19575)

    iskakaushik authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    0541502 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07d5090 View commit details
    Browse the repository at this point in the history
  4. switch const finder to package_config (#19576)

    Generate package config during gclient runhooks and update BUILD.gn to reference it
    Jonah Williams authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    35b5aa5 View commit details
    Browse the repository at this point in the history
  5. Manual roll of Dart 06cb010...69aba23 (#19577)

    Roll Dart from version 69aba23 to 06cb010
    
    dart-lang/sdk@06cb010247 Revert "Add unawaited to package:meta"
    dart-lang/sdk@6de0f53e7c [CFE] Set correct async markers in outline phase (2nd try)
    dart-lang/sdk@b6a0c50bf6 [dart2js] Support conversion of local function type variables from K to J model
    dart-lang/sdk@0ce83987d6 Reland "[SDK] Adds an SDK hash to kernels and the VM."
    dart-lang/sdk@315ecf2606 Roll benchmarks-internal to 88af52754f272e7a4c5737b7e003c2ed9e8a754f
    dart-lang/sdk@3b25d6ff69 Add DynamicType, NeverType, and VoidType to API.
    dart-lang/sdk@11632ff4d4 Add buildSdkSummary() to analyzer API.
    dart-lang/sdk@431b57cbbb Add an additional category into completion_metrics.dart: parameter references
    dart-lang/sdk@4140853675 [dart2js/ddc] Add null checks to with<X|Y|Z|W> methods
    dart-lang/sdk@0d44449aaa Add unawaited to package:meta
    dart-lang/sdk@be0f94b218 [dart2js] include dart:_js_annotations into the platform file by default
    dart-lang/sdk@d9d4e5ccb3 copy package config changes to the modular_suite_nnbd.dart
    dart-lang/sdk@9547628ecf [ddc] Compare types with new DartTypeEquivalence
    dart-lang/sdk@f42889fbb8 create package_config.json files in ddc modular test suite
    dart-lang/sdk@b4c60e6e1c [dart2js] Removing switch class restrictions.
    dart-lang/sdk@935b69e676 [vm] Increase alignment in the blob container format to 16k.
    dart-lang/sdk@901fa79db1 [vm] Prevent bare instructions code from clobbering decisions about which instructions to include.
    dart-lang/sdk@1478b2b71c Prepare to publish analyzer 0.39.12
    dart-lang/sdk@1a60f94fd0 Add two failing tests in the local_reference_contributor_test.dart, after some for(var foo ...) ^, the completion is in the implicit statement which is in the scope of the foo declaration.
    dart-lang/sdk@1b1fcc0618 update package:test in the sdk
    dart-lang/sdk@68bcf1b28a [dartdev] add --enable-experiment support to 'dart test'
    dart-lang/sdk@34ad5a5908 Don't reuse LSP error code that triggers shutdown for refactor errors
    dart-lang/sdk@5d1fbe0497 [cfe] Handle unforseen type parameter intersections
    dart-lang/sdk@878e2cacdd [CFE] Don't issue an initialization error when trying to initialize when not having a platform
    dart-lang/sdk@34f5c9d0b4 [cfe] Implement new async return rules
    dart-lang/sdk@3a4aad6b87 [cfe] Use test description uri for expectation file location
    dart-lang/sdk@fa650e46dd Implement the verbose option for dart analyze
    dart-lang/sdk@b3c9e89028 Roll benchmarks-internal ee36753c0b4b..e6a5aa28c884
    dart-lang/sdk@c40ebbc65e [ DartDev ] Ignore SIGINT in DartDev process
    dart-lang/sdk@bda4994482 Analyzer: Finish using ///-style comments.
    dart-lang/sdk@42d2996773 Analyzer: Move NON_BOOL_* tests to diagnostics/
    a-siva authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    de0932b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b919945 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3fe5edf View commit details
    Browse the repository at this point in the history
  8. [CanvasKit] Dispose the overlay surface when a platform view is dispo…

    …sed (#19546)
    Harry Terkelsen authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a15bc1b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Only attempt surface creation in viewDidLayoutSubviews if the applica…

    …tion is active. (#19592)
    
    UIKit does not guarantee that the application is in the active state when it
    lays out it subviews. However, in `viewDidLayoutSubviews`, Flutter attempts to
    create the render surface and wait for the first frame. These operations require
    GPU access which is forbidden when in the background on iOS. This layout while
    in the background only seems to happen under very specific circumstances as
    described in the reproducible test case. Notably, this behavior cannot be
    reproduced when the application is just launched with the "Background Fetch"
    XCode run scheme. The other instance of invocations to create the rendering
    surface have been audited and I can confirm that those are already in the
    correct lifecycle callbacks. This was the only instance where the surface
    creation was in a non-lifecycle callback.
    
    Fixes flutter/flutter#55969
    (This issue has a clear reproducible test case and was used as the basis for
    verification.)
    Fixes flutter/flutter#57676
    (This is significantly harder to reproduce but the issue looks to be the same. I
    tried this patch on multiple devices overnight and could not reproduce this.)
    
    This underlying cause here was identified by the enhanced GPU error reporting
    introduced in iOS 14. I am not able to submit those patches because the Beta
    builders are not available on infra. I will submit those when available so that
    issues like this have more actionable error messages in the future.
    chinmaygarde authored Jul 8, 2020
    Configuration menu
    Copy the full SHA
    0dc86cd View commit details
    Browse the repository at this point in the history
Loading