Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ce1c1ee54107
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9788bb9ff83e
Choose a head ref
  • 3 commits
  • 19 files changed
  • 3 contributors

Commits on Oct 26, 2023

  1. [Impeller] Disable layer tree screenshots. (#46171) 

    The "rasterizer screenshot" VM service API uses the Skia software backend, even when running with impeller. At best, this leads to confusing half working screenshots that are missing images.

See flutter/flutter#135052

We should disable this functionality when running with impeller. Perhaps this could be reworked to use picture toImage instead of the offscreen so that it uses the "real" backend regardless of the platform it is running on.

Fixes flutter/flutter#135052
    Jonah Williams authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9927539 View commit details
    Browse the repository at this point in the history

  2. [Windows] Refactor high contrast mode detection (#47314) 

    This refactors how high contrast is implemented on Windows:

1. Added a test to verify accessibility features are updated when a view is created. This prevents staleness issues as the Windows embedder isn't notified of accessibility changes while in headless mode.
1. Moved high contrast mode detection to `WindowsProcTable` from `FlutterWindow` to remove engine to view to window plumbing.
1. `FlutterWindow` and `FlutterWindowsEngine` now share their `WindowsProcTable` (which is used for mocking and polyfilling win32 APIs) to reduce redundant dynamic loading.

This pull request contains no functional changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @loic-sharma
    loic-sharma authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    095d27d View commit details
    Browse the repository at this point in the history

  3. Reverts "[Impeller] Disable layer tree screenshots." (#47356) 

    Reverts #46171
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
The "rasterizer screenshot" VM service API uses the Skia software backend, even when running with impeller. At best, this leads to confusing half working screenshots that are missing images.

See flutter/flutter#135052

We should disable this functionality when running with impeller. Perhaps this could be reworked to use picture toImage instead of the offscreen so that it uses the "real" backend regardless of the platform it is running on.

Fixes flutter/flutter#135052
    @auto-submit
    auto-submit[bot] authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9788bb9 View commit details
    Browse the repository at this point in the history
Loading