Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c90fadf45d44
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7c78ea210c19
Choose a head ref
  • 10 commits
  • 51 files changed
  • 6 contributors

Commits on Sep 12, 2023

  1. Use a single OffscreenCanvas for rendering in CanvasKit (#42672) 

    This changes CanvasKit's rendering model. Previously, each overlay
canvas induced a new WebGL context and SkSurface. Now, there is only
ever one SkSurface (backed by an OffscreenCanvas), and the overlays are
HTML canvases with a bitmaprenderer context. The content is rendered
using the SkSurface and passed to the overlays using
`transferToImageBitmap`. This way, there is only one WebGL context in
the lifetime of the app.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @harryterkelsen
    harryterkelsen authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    c5ba843 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (#45729) 

    https://skia.googlesource.com/skia.git/+log/211d63b1e1f5..2d295711337c

2023-09-12 [email protected] Revert "Make SKP deserialize null instead of PNG images by default."
2023-09-12 [email protected] Revert "[skicu] Use cache and respect locale"
2023-09-12 [email protected] Revert "Use over-sampling to avoid branches in 2D blur effect"
2023-09-12 [email protected] Handle new colortype
2023-09-12 [email protected] [graphite] Add Vulkan BackendTexture creation and deletion methods; unit tests
2023-09-12 [email protected] Stop using SkSpecialSurface in ImageFilterTest
2023-09-12 [email protected] Stop using SkSpecialSurface in SkSpecialImageTest

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4519acd View commit details
    Browse the repository at this point in the history

  3. [Impeller] If validations are enabled but not found, still create the… 

    … VK context. (#45674)

Fixes flutter/flutter#131714
    @chinmaygarde
    chinmaygarde authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9a32784 View commit details
    Browse the repository at this point in the history

  4. Added test to assert the vulkan embedder threadsafe vkqueue usage (#4… 

    …5732)

fixes flutter/flutter#133933

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f358bde View commit details
    Browse the repository at this point in the history

  5. [ios] upload extension safe artifacts (#45664) 

    Uploads the artifacts for extension safe build. These artifacts need to be codesigned.

part of flutter/flutter#124291

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4378fe3 View commit details
    Browse the repository at this point in the history

  6. Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... ( 

    #45738)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    865807c View commit details
    Browse the repository at this point in the history

  7. [Impeller] Fix swapchain recreation for non-polling cases. (#45740) 

    Earlier, there was no recovery from vk::Result::eSuboptimalKHR. This made the playground be stuck with a swapchain image size of 1x1 with suboptimal error code on acquisition indefinitely.

Towards fixing the playgrounds. There are still some validation errors.
    @chinmaygarde
    chinmaygarde authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1df0a23 View commit details
    Browse the repository at this point in the history

  8. [Impeller] Patch the compiler to account for subpass inputs and PSO m… 

    …etadata. (#45739)

Towards flutter/flutter#128911

Drive by fixes flutter/flutter#123795
    @chinmaygarde
    chinmaygarde authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6f223db View commit details
    Browse the repository at this point in the history

  9. Revert "Use a single OffscreenCanvas for rendering in CanvasKit" (#45744 

    )

Reverts #42672

This is causing breakages in the Framework roller on golden tests: flutter/flutter#134583
    @harryterkelsen
    harryterkelsen authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    153edff View commit details
    Browse the repository at this point in the history

  10. Revert "Lazily allocate RasterCacheItems only when caching is enabled" ( 

    #45734)

Reverts #45211

b/298583505
    @zanderso
    zanderso authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7c78ea2 View commit details
    Browse the repository at this point in the history
Loading