Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c60b00a20fc3
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5dbcfdc2a456
Choose a head ref
  • 3 commits
  • 9 files changed
  • 3 contributors

Commits on Apr 2, 2024

  1. [skwasm] Fix Paragraph.getLineBoundary (#51846) 

    The Skia APIs I was previously using were returning `-1` for `paragraphGetLineNumberAt` when querying at the end of the string. I changed the implementation to be identical to what CanvasKit and the native Paragraph object are doing.
    @eyebrowsoffire
    eyebrowsoffire authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b1dbb43 View commit details
    Browse the repository at this point in the history

  2. [Embedder API] Add view (#51523) 

    Adds `FlutterEngineAddView` to the embedder API. This will be used to add a view.

Design doc: https://flutter.dev/go/multi-view-embedder-apis

Part of flutter/flutter#144806
Part of flutter/flutter#142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @loic-sharma
    loic-sharma authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d437810 View commit details
    Browse the repository at this point in the history

  3. Do not use adb shell screenrecord during CI runs. (#51848) 

    This introduced quite a bit of flakiness because the system UI sometimes (???) reappears:

![image](https://github.com/flutter/engine/assets/168174/c74a3b88-0d0c-4d03-894a-19837cb4f383)
    @matanlurey
    matanlurey authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    5dbcfdc View commit details
    Browse the repository at this point in the history
Loading