Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c40b0b602822
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f2154ef3e31c
Choose a head ref
  • 8 commits
  • 31 files changed
  • 4 contributors

Commits on Oct 31, 2024

  1. [Impeller] expose reference to tessellator instead of shared_ptr. (#5… 

    …6244)

All geometries were incrementing the shared_ptr usage count which shows up in profiles. Instead expose a Tessellator reference like we do with HostBuffer.
    Jonah Williams authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    cf294fa View commit details
    Browse the repository at this point in the history

  2. Skwasm single threaded (#56206) 

    This PR creates a single-threaded version of the skwasm renderer, appropriate for non-crossOriginIsolated browsing contexts.
* The single threaded renderer is essentially the same as the multi-threaded renderer, except instead of spawning a web worker and posting messages to it, it simply schedules microtasks on the main thread in their place.
* The new renderer is vended as `skwasm_st.js` and `skwasm_st.wasm` in the same location as multithreaded skwasm. In order to properly build and function, we needed some fixes I put into emscripten that landed in version 3.1.70. That version also changed some behavior that required a few fixes to the CanvasKit build files.
* The skwasm loader in flutter.js has been modified to use the skwasm_st variants when encountering a non-crossOriginIsolated context but a browser and configuration that otherwise would allow the use of skwasm. I also added a new `forceSingleThreadedSkwasm` option to the flutter configuration so that we can override this behavior, especially so that we can accurately benchmark the single threaded renderer in a crossOriginIsolated environment.
* I also consolidated a bunch of our shards that run tests to just have one per browser/platform combination, so four total. This will address flutter/flutter#124682
    @eyebrowsoffire
    eyebrowsoffire authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    621e68c View commit details
    Browse the repository at this point in the history

  3. [Impeller] use primitive restart for faster tessellation: write direc… 

    …tly into host buffer. (#56173)

Using primitive restart we can avoid tracking even odd or inserting degenerate triangles. Instead a special index value `0xFFFF` is used to signal a break. This can be combined with triangle fan on vulkan for a dramatically simpler tessellation.

Additionally, switches to a two pass system where we first estimate the storage required by the path so tha the host buffer can be written to directly.
    Jonah Williams authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    48a63fe View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 3c62d4a94d78 to 7e79a516284b (1 revision) (#56252) 

    https://skia.googlesource.com/skia.git/+log/3c62d4a94d78..7e79a516284b

2024-10-31 [email protected] Roll vulkan-deps from 0b52950e91ca to 1d891d46a65c (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d19098f View commit details
    Browse the repository at this point in the history

  5. Roll Dart SDK from 6a8058eef22c to f3e3dc44b1dc (1 revision) (#56253) 

    https://dart.googlesource.com/sdk.git/+log/6a8058eef22c..f3e3dc44b1dc

2024-10-31 [email protected] Version 3.7.0-86.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c61c6d8 View commit details
    Browse the repository at this point in the history

  6. Roll Skia from 7e79a516284b to 4f8f2ecadfb6 (1 revision) (#56255) 

    https://skia.googlesource.com/skia.git/+log/7e79a516284b..4f8f2ecadfb6

2024-10-31 [email protected] Roll Dawn from 35ba6e6c2f96 to a56fede2b5d7 (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d7baf3b View commit details
    Browse the repository at this point in the history

  7. Roll Skia from 4f8f2ecadfb6 to 3c628426f85f (1 revision) (#56261) 

    https://skia.googlesource.com/skia.git/+log/4f8f2ecadfb6..3c628426f85f

2024-10-31 [email protected] Roll Skia Infra from 548705375403 to 65468f93b38c (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3bf6fcc View commit details
    Browse the repository at this point in the history

  8. Reverts "Skwasm single threaded (#56206)" (#56264) 

    Reverts: #56206
Initiated by: jonahwilliams
Reason for reverting: failing to roll into framework: flutter/flutter#157919 
Original PR Author: eyebrowsoffire

Reviewed By: {harryterkelsen}

This change reverts the following previous change:
This PR creates a single-threaded version of the skwasm renderer, appropriate for non-crossOriginIsolated browsing contexts.
* The single threaded renderer is essentially the same as the multi-threaded renderer, except instead of spawning a web worker and posting messages to it, it simply schedules microtasks on the main thread in their place.
* The new renderer is vended as `skwasm_st.js` and `skwasm_st.wasm` in the same location as multithreaded skwasm. In order to properly build and function, we needed some fixes I put into emscripten that landed in version 3.1.70. That version also changed some behavior that required a few fixes to the CanvasKit build files.
* The skwasm loader in flutter.js has been modified to use the skwasm_st variants when encountering a non-crossOriginIsolated context but a browser and configuration that otherwise would allow the use of skwasm. I also added a new `forceSingleThreadedSkwasm` option to the flutter configuration so that we can override this behavior, especially so that we can accurately benchmark the single threaded renderer in a crossOriginIsolated environment.
* I also consolidated a bunch of our shards that run tests to just have one per browser/platform combination, so four total. This will address flutter/flutter#124682
    @auto-submit
    auto-submit[bot] authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f2154ef View commit details
    Browse the repository at this point in the history
Loading