Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c380e9fd4122
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 98a800b00cfc
Choose a head ref
  • 3 commits
  • 28 files changed
  • 2 contributors

Commits on May 3, 2024

  1. [Impeller] Remove Entity capture/AiksInspector. (#52526) 

    Resolves flutter/flutter#134748.

This was a really fun experiment. I learned a lot from it, and it genuinely helped me solve some coverage-related problems, but the reality is it was too little too late -- by the time we had this capture system, we had already solved most of the problems that would have benefitted from this.

It's been a few months since I've used or extended the capabilities of this capture system for something, and I don't have the spare time/energy to give it the love it needs to realize the vision I had for it. I still almost exclusively use a combination of native frame captures and print debugging to solve problems.

RIP in peace.
    @bdero
    bdero authored May 3, 2024
    Configuration menu
    Copy the full SHA
    4846886 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from df970dcd6cfa to 2eaea0383201 (1 revision) (#52536) 

    https://skia.googlesource.com/skia.git/+log/df970dcd6cfa..2eaea0383201

2024-05-02 [email protected] Roll vulkan-deps from 23709f0474fe to 1526c466aadc (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 3, 2024
    Configuration menu
    Copy the full SHA
    fe6a54d View commit details
    Browse the repository at this point in the history

  3. [et] Add ios_debug_unopt build config. (#52537) 

    Resolves flutter/flutter#147757
    @bdero
    bdero authored May 3, 2024
    Configuration menu
    Copy the full SHA
    98a800b View commit details
    Browse the repository at this point in the history
Loading