Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c27109291e22
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9c83d90b01bd
Choose a head ref
  • 5 commits
  • 20 files changed
  • 4 contributors

Commits on Aug 7, 2023

  1. Revert clang back to 6d667d4b261e81f325756fdfd5bb43b3b3d2451d (#44442) 

    b/294820516


https://stackoverflow.com/questions/76852785/how-to-fix-itms-90338-non-public-api-usage-issue-after-review
    @zanderso
    zanderso authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4c6714b View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 9fbd7296de9a to d1ada6624536 (1 revision) (#44447) 

    https://skia.googlesource.com/skia.git/+log/9fbd7296de9a..d1ada6624536

2023-08-07 [email protected] Use explicit versioning with Python.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b0d4151 View commit details
    Browse the repository at this point in the history

  3. Fix use-after-free crash in glfw embedder (#44358) 

    When setting up the paths to assets and ICU data, we were previously returning the underlying char* data in a temporary string returned by `std::filesystem::path::string()`. Since the return value of `string()` is never stored, there's no guarantee that the underlying data pointer is still valid later in the function. By storing the string in a local whose lifetime exceeds that of the running engine instance, we guarantee the string isn't freed until after the Flutter app terminates.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @ftsui
    ftsui authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4505525 View commit details
    Browse the repository at this point in the history

  4. [Impeller] Flutter GPU: Add GpuContext. (#44359) 

    Move the GpuContext to its new home. I added a `flutter_tester` test that just verifies an exception is gracefully thrown when Impeller isn't available.

In a later patch, I'll land a way to eagerly supply the Impeller context on the cpp side to enable testing through the playground (as mentioned in flutter/flutter#127712).
    @bdero
    bdero authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6ec3566 View commit details
    Browse the repository at this point in the history

  5. Roll Dart SDK from 0816d590a220 to f664f4b9c50d (1 revision) (#44462) 

    https://dart.googlesource.com/sdk.git/+log/0816d590a220..f664f4b9c50d

2023-08-07 [email protected] Version 3.2.0-42.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9c83d90 View commit details
    Browse the repository at this point in the history
Loading