Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c11d64be5102
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 65ac4bf96ed7
Choose a head ref
  • 3 commits
  • 7 files changed
  • 2 contributors

Commits on May 16, 2024

  1. Roll Skia from bbe06eb4a8e9 to 91527e447923 (1 revision) (#52864) 

    https://skia.googlesource.com/skia.git/+log/bbe06eb4a8e9..91527e447923

2024-05-15 [email protected] Reland 2: Add ISO 21496-1 gainmap parsing

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 16, 2024
    Configuration menu
    Copy the full SHA
    29cca4a View commit details
    Browse the repository at this point in the history

  2. Revamp the engine style guide, remove always_specify_types. (#52859) 

    Based on the (internal) discussion around converging on using the official Dart style guide, with the exception of the code that gets published under `dart:ui`, as that is user-facing, and we'd like to evolve the code style in conjunction with the framework.

I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of `shared_ptr` and `auto` in some cases). I am happy to split those up, but it was easier to make the markdown changes at once.

I also took @cbracken and folks advice and clarified directly that explicit types in Dart are _not_ bad (with examples).
    @matanlurey
    matanlurey authored May 16, 2024
    Configuration menu
    Copy the full SHA
    e6e37b4 View commit details
    Browse the repository at this point in the history

  3. Include stdout on a failed gn desc call, and test for it. (#52863) 

    Fixes flutter/flutter#148431, in that full error output is now shown.

I also filed an additional issue for how we could do better: flutter/flutter#148442.
    @matanlurey
    matanlurey authored May 16, 2024
    Configuration menu
    Copy the full SHA
    65ac4bf View commit details
    Browse the repository at this point in the history
Loading