Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bfd2ffb9a8bc
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b40042ebb95b
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Oct 19, 2023

  1. Fix use of nested designators (#45869) 

    There was an internal global change which turned `-Wc99-designator`. This causes the following error:

```
error: nested designators are a C99 extension [-Werror,-Wc99-designator]
   65 |       .metal.struct_size = sizeof(FlutterMetalRendererConfig),
      |       ^~~~~~~~~~~~~~~~~~
```

This seems like a trivial (?) fix, so perhaps we can fix it properly and possibly remove https://github.com/flutter/buildroot/blob/b9fbd310d6fa68f888738d5236ea2f6caa2d2bfc/build/config/compiler/BUILD.gn#L667 after this PR lands.

*List which issues are fixed by this PR. You must list at least one issue.*

b/300573112

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @jiahaog
    jiahaog authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    cdd21f8 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 04449cda5a0a to b540ed3ba8e7 (4 revisions) (#47118) 

    https://skia.googlesource.com/skia.git/+log/04449cda5a0a..b540ed3ba8e7

2023-10-19 [email protected] Add index.d.ts to debugger and jsfiddle images
2023-10-19 [email protected] Fix IWYU
2023-10-19 [email protected] Manual roll Dawn from 7317f665cc52 to 4759145c009e (8 revisions)
2023-10-19 [email protected] Fix ClangTidy `performance-unnecessary-value-param` findings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b40042e View commit details
    Browse the repository at this point in the history
Loading