Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bf1c6da0dd31
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 41b86b59f0ab
Choose a head ref
  • 15 commits
  • 25 files changed
  • 4 contributors

Commits on May 15, 2024

  1. Re-add MipFilter::kBase, but keep kNearest as the default. (#52779) 

    Closes flutter/flutter#147259.

Changes:
- Make sure the default of `kNearest` is used consistently
- Partial revert of #40491, re-adding `kBase`
- Added some documentation about relevant enums, and why the default is `kNearest`
- Wired up `kBase` in the Metal, Vulkan, and OpenGLES backends

Expecting an update to the `dart_ui_filter_quality_none` golden file:

> ![Screenshot 2024-05-13 at 2 47 49�PM](https://github.com/flutter/engine/assets/168174/68df4c1a-9b2b-4201-9a6c-f78361a5aa30)

For breadcrumbs around the mapping, see flutter/flutter#148253.
    @matanlurey
    matanlurey authored May 15, 2024
    Configuration menu
    Copy the full SHA
    f0e4350 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from d0d87c26b489 to fad584324d85 (1 revision) (#52831) 

    https://skia.googlesource.com/skia.git/+log/d0d87c26b489..fad584324d85

2024-05-15 [email protected] graphite: Do not call virtual setBackendLabel in Resource constructor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    0d7e7de View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from 0b77fbab8cf5 to 1eec9de2f9c6 (1 revision) (#52833) 

    https://dart.googlesource.com/sdk.git/+log/0b77fbab8cf5..1eec9de2f9c6

2024-05-15 [email protected] Version 3.5.0-155.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    7d8b4eb View commit details
    Browse the repository at this point in the history

  4. Migrate SemanticsObject and FlutterSemanticsScrollView to ARC (#52824) 

    On top of the `SemanticsObject` refactor #52729 migrate `SemanticsObject` and `FlutterSemanticsScrollView` to ARC.

Part of flutter/flutter#137801.
    @jmagman
    jmagman authored May 15, 2024
    Configuration menu
    Copy the full SHA
    57d6b29 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from fad584324d85 to c0caf10486ce (1 revision) (#52835) 

    https://skia.googlesource.com/skia.git/+log/fad584324d85..c0caf10486ce

2024-05-15 [email protected] Roll Dawn from 166c9d5d561d to 0a7ce7cacd1b (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    e12bd40 View commit details
    Browse the repository at this point in the history

  6. Roll Skia from c0caf10486ce to b3aadd56d187 (3 revisions) (#52837) 

    https://skia.googlesource.com/skia.git/+log/c0caf10486ce..b3aadd56d187

2024-05-15 [email protected] Roll vulkan-deps from 724dbf0e90cb to e127b96b4799 (6 revisions)
2024-05-15 [email protected] Roll SK Tool from c8e24928e2f9 to a21a77992dab
2024-05-15 [email protected] Roll Skia Infra from b43af3a7d497 to c8e24928e2f9 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    2b89c00 View commit details
    Browse the repository at this point in the history

  7. Roll Skia from b3aadd56d187 to a9ba7411d4b2 (1 revision) (#52839) 

    https://skia.googlesource.com/skia.git/+log/b3aadd56d187..a9ba7411d4b2

2024-05-15 [email protected] Reland: Add ISO 21496-1 gainmap parsing

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    d0d2114 View commit details
    Browse the repository at this point in the history

  8. Roll Dart SDK from 1eec9de2f9c6 to 7d9de0c0b231 (1 revision) (#52841) 

    https://dart.googlesource.com/sdk.git/+log/1eec9de2f9c6..7d9de0c0b231

2024-05-15 [email protected] Version 3.5.0-156.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    db70939 View commit details
    Browse the repository at this point in the history

  9. Roll Skia from a9ba7411d4b2 to 4a7419d662d5 (1 revision) (#52844) 

    https://skia.googlesource.com/skia.git/+log/a9ba7411d4b2..4a7419d662d5

2024-05-15 [email protected] [graphite] Make MatrixConvolutionImageFilter stably keyed (take 2)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    97b5053 View commit details
    Browse the repository at this point in the history

  10. Roll Skia from 4a7419d662d5 to 475559da107d (5 revisions) (#52848) 

    https://skia.googlesource.com/skia.git/+log/4a7419d662d5..475559da107d

2024-05-15 [email protected] [Graphite] Don't set DawnTexture label if we only have a view.
2024-05-15 [email protected] Update Windows P400s to Windows 22H2 and latest driver
2024-05-15 [email protected] Revert "Reland: Add ISO 21496-1 gainmap parsing"
2024-05-15 [email protected] Revert "graphite: Do not call virtual setBackendLabel in Resource constructor"
2024-05-15 [email protected] [bazel] Add target for svg_writer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    a759aba View commit details
    Browse the repository at this point in the history

  11. Roll buildroot (#52826) 

    This PR rolls in the buildroot to pick up
flutter/buildroot#858.
    @zanderso
    zanderso authored May 15, 2024
    Configuration menu
    Copy the full SHA
    7048a7a View commit details
    Browse the repository at this point in the history

  12. Roll Dart SDK from 7d9de0c0b231 to f773d45634ed (2 revisions) (#52854) 

    https://dart.googlesource.com/sdk.git/+log/7d9de0c0b231..f773d45634ed

2024-05-15 [email protected] Version 3.5.0-158.0.dev
2024-05-15 [email protected] Version 3.5.0-157.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    74bd77c View commit details
    Browse the repository at this point in the history

  13. Roll Fuchsia Linux SDK from NbCi2ETfLHPLLB-JV... to Ftw7GopnudHydGS1y… 

    …... (#52853)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    7f602a2 View commit details
    Browse the repository at this point in the history

  14. Migrate TextInputSemanticsObject to ARC (#52785) 

    1. Migrate TextInputSemanticsObject to ARC
2. Rename the Objective-C-only `accessibility_text_entry.*` files to `TextInputSemanticsObject.*`
3. Move `FlutterInactiveTextInput` interface from the header file into the implementation, the only place it's used.

Blocked on `SemanticsObject` ARC migration #52824

Part of flutter/flutter#137801.
    @jmagman
    jmagman authored May 15, 2024
    Configuration menu
    Copy the full SHA
    e473cff View commit details
    Browse the repository at this point in the history

  15. Roll Skia from 475559da107d to b9a304eb05d2 (1 revision) (#52857) 

    https://skia.googlesource.com/skia.git/+log/475559da107d..b9a304eb05d2

2024-05-15 [email protected] SkJpegEncoder: Specify metadata segments explicitly

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 15, 2024
    Configuration menu
    Copy the full SHA
    41b86b5 View commit details
    Browse the repository at this point in the history
Loading