Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bedc49efc85c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a198ad4e740d
Choose a head ref
  • 20 commits
  • 56 files changed
  • 7 contributors

Commits on Oct 26, 2023

  1. Configuration menu
    Copy the full SHA
    d74261e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c60f43b View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (#…

    …47357)
    
    Manual roll requested by [email protected]
    
    https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7
    
    2023-10-26 [email protected] Version 3.3.0-65.0.dev
    2023-10-26 [email protected] Version 3.3.0-64.0.dev
    2023-10-26 [email protected] Version 3.3.0-63.0.dev
    2023-10-26 [email protected] Version 3.3.0-62.0.dev
    2023-10-26 [email protected] Version 3.3.0-61.0.dev
    2023-10-25 [email protected] Version 3.3.0-60.0.dev
    2023-10-25 [email protected] Version 3.3.0-59.0.dev
    2023-10-25 [email protected] Version 3.3.0-58.0.dev
    2023-10-24 [email protected] Version 3.3.0-57.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    bc15dff View commit details
    Browse the repository at this point in the history
  2. Don't re-initialize the default RenderSurface when returning from hyb…

    …rid composition mode (#47358)
    
    When we enter hybrid composition mode we 'pause' the default RenderSurface (implemented by SurfaceView or TextureView) and swap to an ImageReader based RenderSurface.
    
    When we return from hybrid composition mode we recreate and re-initialize the real RenderSurface as if it was being used for the first time.
    
    This broke Platform Views in an internal app b/306122497 because we would incorrectly tell the texture to attach when it was never detached.
    
    This CL changes the protocol so that when we return from hybrid composition mode we only swap the RenderSurface and do not re-create it. This avoids doing a bunch of unnecessary work and fixes the logic error of re-attaching textures that were never detached.
    
    *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    johnmccutchan authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    7119498 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dbcf074 View commit details
    Browse the repository at this point in the history
  4. [Impeller] Add FilterContents::GetSourceCoverage to enable filtered s…

    …aveLayer clipping. (#47183)
    
    The new method allows a caller to ask for the coverage of the input pixels required to produce an output that spans a given area. This allows the code to clip a saveLayer that has an image filter applied to it.
    flar authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    786202e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8a5fb39 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d6bbca9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b274bc3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cdd4bb4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4913feb View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    48137f0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d90fbf1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    233295f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d799dc7 View commit details
    Browse the repository at this point in the history
  14. Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 re…

    …visions)" (#47380)
    
    Reverts #47357
    Initiated by: zanderso
    This change reverts the following previous change:
    Original Description:
    
    Manual roll requested by [email protected]
    
    https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7
    
    2023-10-26 [email protected] Version 3.3.0-65.0.dev
    2023-10-26 [email protected] Version 3.3.0-64.0.dev
    2023-10-26 [email protected] Version 3.3.0-63.0.dev
    2023-10-26 [email protected] Version 3.3.0-62.0.dev
    2023-10-26 [email protected] Version 3.3.0-61.0.dev
    2023-10-25 [email protected] Version 3.3.0-60.0.dev
    2023-10-25 [email protected] Version 3.3.0-59.0.dev
    2023-10-25 [email protected] Version 3.3.0-58.0.dev
    2023-10-24 [email protected] Version 3.3.0-57.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    auto-submit[bot] authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    71e1a04 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e18ba82 View commit details
    Browse the repository at this point in the history
  16. [Impeller] Enable GLES MSAA only if the multisampled_render_to_textur…

    …e2 extension is available (#47364)
    
    The GLES MSAA implementation may need to call FramebufferTexture2DMultisampleEXT for the stencil attachment.
    
    See flutter/flutter#137252
    jason-simmons authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    674de5b View commit details
    Browse the repository at this point in the history
  17. Move rapidjson to flutter/third_party (#47354)

    As part of eliminating the Flutter buildroot
    (flutter/flutter#67373), we are moving all
    third-party dependencies from //third_party to //flutter/third_party.
    
    Once all third-party dependencies have been migrated, tooling and config
    will be moved and the buildroot will be eliminated altogether.
    
    No tests changed because there is no semantic change to this PR. This is
    simply relocating a dependency.
    zanderso authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    5176c81 View commit details
    Browse the repository at this point in the history
  18. [Impeller] Add present wait latch. (#47311)

    It turns out the fixing #47249 revealed further bugs: we were actually overwriting previous presents and dropping frames, which was what the forward progress error was hinting. Once this problem is fixed, we started hitting present timeouts or overdraw of swapchain images.
    
    The fix for this is that we shouldn't even ask for a swapchain image until after we've called present, which actually wasn't tracked with anything.
    
    The error:
    
    ```
    A Dart VM Service on Pixel 6 Pro is available at: http://127.0.0.1:62491/_N4PSEPUtA0=/
    The Flutter DevTools debugger and profiler on Pixel 6 Pro is available at: http://127.0.0.1:9102?uri=http://127.0.0.1:62491/_N4PSEPUtA0=/
    W/OnBackInvokedCallback(19160): OnBackInvokedCallback is not enabled for the application.
    W/OnBackInvokedCallback(19160): Set 'android:enableOnBackInvokedCallback="true"' in the application manifest.
    W/vulkan  (19160): dequeueBuffer timed out: Function not implemented (-38)
    E/flutter (19160): [ERROR:flutter/impeller/base/validation.cc(49)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not acquire next swapchain image: Timeout
    E/flutter (19160): [ERROR:flutter/shell/gpu/gpu_surface_vulkan_impeller.cc(64)] No surface available.
    ```
    Jonah Williams authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    a198ad4 View commit details
    Browse the repository at this point in the history
Loading