Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bd58d2b2d655
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 69f2d9610a18
Choose a head ref
  • 7 commits
  • 11 files changed
  • 4 contributors

Commits on May 8, 2024

  1. Roll Fuchsia Linux SDK from 27ZAbzJkEopmu0Emp... to RDVdjRvCxkJh2NLxS… 

    …... (#52685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 8, 2024
    Configuration menu
    Copy the full SHA
    6c1f46c View commit details
    Browse the repository at this point in the history

  2. Reland "Add host_profile_arm64 and host_release_arm64 local engine co… 

    …nfigurations." (#52633)

Adds --no-lto.

This reverts commit 1fe835b.
    @chinmaygarde
    chinmaygarde authored May 8, 2024
    Configuration menu
    Copy the full SHA
    eafdd2f View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 76f88de905be to df446841e3cd (3 revisions) (#52686) 

    https://skia.googlesource.com/skia.git/+log/76f88de905be..df446841e3cd

2024-05-08 [email protected] [graphite] Move CopyAsDraw into TextureUtils
2024-05-08 [email protected] Roll skottie-base from 6d0d7269a8c9 to 8ecbf179f1e3
2024-05-08 [email protected] [fontations] Use %zu instead of %ld in test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 8, 2024
    Configuration menu
    Copy the full SHA
    45ddb29 View commit details
    Browse the repository at this point in the history

  4. [Impeller] initialize ahb swapchain with max entries. (#52670) 

    The regression on the complex layout app is due to lazily constructing the AHBs on the first few frames:

https://flutter-flutter-perf.skia.org/e/?begin=1712175722&end=1715166324&queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dcomplex_layout_scroll_perf_impeller__timeline_summary&requestType=0&selected=commit%3D40701%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253Dworst_frame_rasterizer_time_millis%252Ctest%253Dcomplex_layout_scroll_perf_impeller__timeline_summary%252C

Lets try eager initialization like the KHR swapchain does.
    Jonah Williams authored May 8, 2024
    Configuration menu
    Copy the full SHA
    3fb0011 View commit details
    Browse the repository at this point in the history

  5. Fix UIVisualEffectView leak in platform view filter (#52591) 

    I found this while migrating `FlutterPlatformViews_Internal.mm` to ARC #52535.  I'll land this first.

```objc
  if (_backdropFilterView != visualEffectView) {
    _backdropFilterView = [visualEffectView retain];
  }
```
should instead be something like:
```objc
  if (_backdropFilterView != visualEffectView) {
    id oldBackdropFilterView = _backdropFilterView;
    _backdropFilterView = [visualEffectView retain];
    [oldBackdropFilterView release];
  }
```
But that's already what the built-in MRC `nonatomic, retain` property setter does, so use that instead.

Added a test that passes on this PR and fails on main.
    @jmagman
    jmagman authored May 8, 2024
    Configuration menu
    Copy the full SHA
    dc6e438 View commit details
    Browse the repository at this point in the history

  6. Roll Skia from df446841e3cd to 4e83fac12783 (2 revisions) (#52688) 

    https://skia.googlesource.com/skia.git/+log/df446841e3cd..4e83fac12783

2024-05-08 [email protected] Revert "[graphite] Make MatrixConvolutionImageFilter stably keyed"
2024-05-08 [email protected] [graphite] Include Recording creation & submit in Viewer flush times

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 8, 2024
    Configuration menu
    Copy the full SHA
    0ea962d View commit details
    Browse the repository at this point in the history

  7. Roll Skia from 4e83fac12783 to 91088addfbd9 (1 revision) (#52691) 

    https://skia.googlesource.com/skia.git/+log/4e83fac12783..91088addfbd9

2024-05-08 [email protected] SkJpegMetadataDecoder: Clean-up and de-duplicate code

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 8, 2024
    Configuration menu
    Copy the full SHA
    69f2d96 View commit details
    Browse the repository at this point in the history
Loading