Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bd165dc27166
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: da71729651d8
Choose a head ref
  • 7 commits
  • 73 files changed
  • 3 contributors

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    3a63daf View commit details
    Browse the repository at this point in the history
  2. [DisplayList] migrate DlColorFilter objects to new source layout (#56785

    )
    
    A new source code/header structure was introduced when the DlColorSource and DlImageFilter objects were migrated to Impeller geometry classes. Even though the DlColorFilter objects did not depend on Skia geometry objects, they need to be updated to the new source layout for consistency.
    flar authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    9975c85 View commit details
    Browse the repository at this point in the history
  3. [Impeller] cache even more text frame data to skip lookups. (#56798)

    Every text frame must inform the glyph atlas about the glyphs + scale it contains. When this happens, the glyph atlas will populate the glyph and then tell teh text frame about the location in the atlas, so that the text contents shader can sample it correctly.
    
    Once this has been done once for a given text frame + scale + offset, we can actually just keep reusing the same data provided 1) the atlas itself hasn't changed and 2) the scale/offset/properties are the same.
    
    This constitutes a nice CPU usage reduction in places where there is a lot of text that isn't being invalidated, like scrolling on the flutter gallery.
    Jonah Williams authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    65c8c6e View commit details
    Browse the repository at this point in the history
  4. [engine] reland: more consistently flush message loops tasks (#56815)

    Changes the following shell callbacks to flush the dart event loop:
    
    * OnPlatformViewSetViewportMetrics
    * OnPlatformViewDispatchPointerDataPacket
    * OnPlatformViewDispatchPlatformMessage
    * OnPlatformViewSetSemanticsEnabled
    * OnPlatformViewSetAccessibilityFeatures
    Using a new TaskRunner API RunNowAndFlushMessages. If the task runner can run tasks on the current thread, this will immediately invoke a callback and then post an empty task to the event loop to ensure dart listeners fire.
    
    Unlike #56738, does not touch the vsync API - which looks like it depends on scheduling behavior today, at least for iOS.
    Jonah Williams authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    91f250b View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. [DisplayList] Delete (publicly) unused DlColorColorSource (#56825)

    While recently updating the DlColorSource sources I noticed some questionably implementation choices in the Color variant of the color sources.
    
    I then realized that there was no public use of these classes (other than mostly their own unit tests) and so they should be deleted to focus on implementing the variants that are actually used by Flutter.
    flar authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    9c31f64 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db40e03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    da71729 View commit details
    Browse the repository at this point in the history
Loading