Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b71b366e3de3
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 154d6fd601a3
Choose a head ref
  • 6 commits
  • 22 files changed
  • 5 contributors

Commits on Sep 13, 2023

  1. [Impeller] Fixes stroke path geometry that can draw outside of path i… 

    …f the path ends at sharp turn. (#45252)

Fixes flutter/flutter#133032

The issue is that when we draw a line we always try to draw a complete rectangle from point 1 to point2 before drawing the join and the next line
![Untitled drawing (7)](https://github.com/flutter/engine/assets/47866232/c51aa4a8-bd8e-4764-9941-4e2968b4fb8e)

This becomes a problem if there is a sharp turn
![Untitled drawing (6)](https://github.com/flutter/engine/assets/47866232/2b743792-52b7-402d-b2e8-f08ed47c0943)

![Untitled drawing (5)](https://github.com/flutter/engine/assets/47866232/794a75c9-5e87-4548-a264-7dd9cf088ae7)

Notice there will be a slight over drawing at the bottom.

The solution then is to not draw the rect first before drawing the join. It will be the join's responsibility to draw the complete the rect from the line start to the join.

This should also save a lot of repeatedly drawing during the join
![rect](https://github.com/flutter/engine/assets/47866232/24802df6-69b5-4543-8d09-fcfbff4cedbb)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @chunhtai
    chunhtai authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    343dfe8 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 78d18d509475 to 471216072c74 (4 revisions) (#45774) 

    https://skia.googlesource.com/skia.git/+log/78d18d509475..471216072c74

2023-09-13 [email protected] [graphite] Rename AtlasShape to CoverageMaskShape.
2023-09-13 [email protected] Add SkASSERTF_RELEASE
2023-09-13 [email protected] [sksl] Support dual-src blending in Dawn
2023-09-13 [email protected] Reland "Use over-sampling to avoid branches in 2D blur effect"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    cad3646 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Remove dependency on //flutter/vulkan and use a single pro… 

    …c table. (#45741)

Fixes flutter/flutter#121947
    @chinmaygarde
    chinmaygarde authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    cf1c3a1 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 471216072c74 to e39cf360ea93 (4 revisions) (#45776) 

    https://skia.googlesource.com/skia.git/+log/471216072c74..e39cf360ea93

2023-09-13 [email protected] [graphite] Begin refactoring paint key creation
2023-09-13 [email protected] Reland "Add epsilon to texture effect clamping at pixel centers"
2023-09-13 [email protected] [sksl] Raise feature errors before code generation
2023-09-13 [email protected] Bring back SkNoPixelsDevice::resetForNextPicture

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    bc7bb64 View commit details
    Browse the repository at this point in the history

  5. Revert "[Impeller] Patch the compiler to account for subpass inputs a… 

    …nd PSO metadata." (#45777)

Reverts #45739
fixes flutter/flutter#134666
    @gaaclarke
    gaaclarke authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    2049b69 View commit details
    Browse the repository at this point in the history

  6. Auto update dependencies for web_ui. (#45754) 

    This is to autofix problems like: https://github.com/flutter/engine/security/dependabot

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    154d6fd View commit details
    Browse the repository at this point in the history
Loading