Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b466a0dd7834
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e61bc853acb2
Choose a head ref
  • 5 commits
  • 18 files changed
  • 4 contributors

Commits on Sep 30, 2024

  1. Roll Skia from 06721a724831 to dfeeb199b226 (2 revisions) (#55524) 

    https://skia.googlesource.com/skia.git/+log/06721a724831..dfeeb199b226

2024-09-30 [email protected] Check for null child in SkWorkingFormatColorFilter
2024-09-30 [email protected] Add bungeman to public API owners

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b89b82c View commit details
    Browse the repository at this point in the history

  2. Roll Dart SDK from c55ae50d619a to 79863e31de87 (1 revision) (#55525) 

    https://dart.googlesource.com/sdk.git/+log/c55ae50d619a..79863e31de87

2024-09-30 [email protected] Version 3.6.0-301.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e8f9339 View commit details
    Browse the repository at this point in the history

  3. Reland [skwasm] Scene builder optimizations for platform view placeme… 

    …nt (#55468)

This is an attempt to reland the overlay optimization for skwasm and fixing the golden diffs from the framework tests.

Original PR description:

This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: flutter/flutter#149863

This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
    @eyebrowsoffire
    eyebrowsoffire authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    def85c7 View commit details
    Browse the repository at this point in the history

  4. iOS: Migrate FlutterEngineGroup to ARC (#55503) 

    This migrates FlutterEngineGroup to automatic reference counting. It also migrates `enginesCreatedCount` from an ivar to property syntax.

I'll look at migrating engine from `NSMutableArray<NSValue*>` to a weak pointer array in a followup patch since it's orthogonal to ARC migration.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5e08e4f View commit details
    Browse the repository at this point in the history

  5. fix use_of_uninitialized_value in message_loop_task_queues.cc (#55520) 

    This issue was found with memory sanitizer.

    Commit f2f09b6 introduced a change that leads to use-after-free condition.

    In function MessageLoopTaskQueues::GetNextTaskToRun:

        1) Call is made to PeekNextTaskUnlocked(queue_id);. Returned value contains a reference to to an object of const DelayedTask& taken from an std::queue container as returned by primary_task_queue_.top().
        2) Variable TaskSource::TopTask top now contains a reference to this object.
        3) Function queue_entries_.at(top.task_queue_id)->task_source->PopTask(...) which in turn calls pop() method on std::queue.
        4) Object of type DelayedTask on top of the queue gets deleted.
        5) top.task.GetTaskSourceGrade() is called later with top.task refering to an already deleted object.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @art-snake
    art-snake authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e61bc85 View commit details
    Browse the repository at this point in the history
Loading