Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b0a4ca92c49e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 877abb9ad6ff
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Nov 12, 2024

  1. [Impeller] Add OpenGL debugging utilities. (#56515) 

    * CheckFramebufferStatus needs to be called with the enum for the target type and not the target itself.
* Fix dumping the framebuffer type and object name.

The results should be the following for the default FBO0.
```
[IMPORTANT:flutter/impeller/renderer/backend/gles/render_pass_gles.cc(281)] The default framebuffer (FBO0) was bound.
```

and the following for an offscreen framebuffer:
```
[IMPORTANT:flutter/impeller/renderer/backend/gles/render_pass_gles.cc(281)] The default framebuffer (FBO0) was bound.
[IMPORTANT:flutter/impeller/renderer/backend/gles/render_pass_gles.cc(281)] FBO 1: GL_FRAMEBUFFER_COMPLETE
Framebuffer is complete.
Description: 
Color Attachment: GL_TEXTURE(5)
Depth Attachment: GL_RENDERBUFFER(1)
Stencil Attachment: GL_RENDERBUFFER(1)

```

cc @lyceel
    @chinmaygarde
    chinmaygarde authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3a5c6b4 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 75230dbc93e6 to aa099ff91e2f (3 revisions) (#56525) 

    https://skia.googlesource.com/skia.git/+log/75230dbc93e6..aa099ff91e2f

2024-11-12 [email protected] Roll Skia Infra from cf848e50c100 to 4448a7219f6d (7 revisions)
2024-11-12 [email protected] Roll SwiftShader from 76855a9baecc to d5c428477411 (1 revision)
2024-11-12 [email protected] Roll Dawn from 2a86250e561c to 04483c84503c (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    877abb9 View commit details
    Browse the repository at this point in the history
Loading