Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ab9daaa0bcc7
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4d8d8517a0ff
Choose a head ref
  • 12 commits
  • 57 files changed
  • 7 contributors

Commits on Sep 13, 2024

  1. add back test itSendsTextShowPasswordToFrameworkOnAttach with new moc…

    …k for display metrics (#55110)
    
    Part 1/5 for re adding tests documented in flutter/flutter/issues/154746
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I signed the [CLA].
    - [x] All existing and new tests are passing.
    reidbaker authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1595e21 View commit details
    Browse the repository at this point in the history
  2. [skwasm] Scene builder optimizations for platform view placement (#54949

    )
    
    This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: flutter/flutter#149863
    
    This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
    eyebrowsoffire authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    950f92f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    715ede5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    94f56a2 View commit details
    Browse the repository at this point in the history
  5. [impeller] add Android flag for disabling surface control for debuggi…

    …ng. (#55185)
    
    I've found a few instances where Vulkan worked correctly but surface control did not. lets add a debugging flag we can ask folks to try to narrow down the issue.
    Jonah Williams authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8aa8b53 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7fcef5f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3808101 View commit details
    Browse the repository at this point in the history
  8. Delete VolatilePathTracker in favor of Dispatch tracking (#55125)

    ui.Canvas and ui.SceneBuilder now use the DlPath object directly from the ui.Path object. This results in increased sharing of the wrapper objects which then increases the sharing of both the converted Impeller paths and Skia's volatile flag.
    
    The VolatilePathTracker mechanism is deleted and rather than count the number of frames that a path is stable for, instead we count the number of times it is used for rendering. If a path is used 100 times in a single frame, it will become non-volatile and start being cached almost immediately. The cached Impeller paths are now also tracked for all instances of the same path, rather than for each call site that originated from a DisplayList dispatch.
    flar authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3eca8fd View commit details
    Browse the repository at this point in the history
  9. Reverts "[skwasm] Scene builder optimizations for platform view place…

    …ment (#54949)" (#55193)
    
    Reverts: #54949
    Initiated by: eyebrowsoffire
    Reason for reverting: Incorrect golden diffs on engine roll, see flutter/flutter#155181
    Original PR Author: eyebrowsoffire
    
    Reviewed By: {harryterkelsen}
    
    This change reverts the following previous change:
    This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: flutter/flutter#149863
    
    This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
    auto-submit[bot] authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dfb04f3 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6477f87 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b58992a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    4d8d851 View commit details
    Browse the repository at this point in the history
Loading