-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: ab9daaa0bcc7
head repository: flutter/engine
compare: 4d8d8517a0ff
- 12 commits
- 57 files changed
- 7 contributors
Commits on Sep 13, 2024
-
add back test itSendsTextShowPasswordToFrameworkOnAttach with new moc…
…k for display metrics (#55110) Part 1/5 for re adding tests documented in flutter/flutter/issues/154746 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing.
Configuration menu - View commit details
-
Copy full SHA for 1595e21 - Browse repository at this point
Copy the full SHA 1595e21View commit details -
[skwasm] Scene builder optimizations for platform view placement (#54949
) This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: flutter/flutter#149863 This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
Configuration menu - View commit details
-
Copy full SHA for 950f92f - Browse repository at this point
Copy the full SHA 950f92fView commit details -
Roll Dart SDK from eb664303c5ff to 302b6472b849 (2 revisions) (#55182)
https://dart.googlesource.com/sdk.git/+log/eb664303c5ff..302b6472b849 2024-09-13 [email protected] Version 3.6.0-253.0.dev 2024-09-13 [email protected] Version 3.6.0-252.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 715ede5 - Browse repository at this point
Copy the full SHA 715ede5View commit details -
Roll Skia from a5a6d12b3642 to 9877f459399a (2 revisions) (#55187)
https://skia.googlesource.com/skia.git/+log/a5a6d12b3642..9877f459399a 2024-09-13 [email protected] Rename our_vulkan_headers use_skia_vulkan_headers 2024-09-13 [email protected] [bazel] Initial dm support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 94f56a2 - Browse repository at this point
Copy the full SHA 94f56a2View commit details -
[impeller] add Android flag for disabling surface control for debuggi…
…ng. (#55185) I've found a few instances where Vulkan worked correctly but surface control did not. lets add a debugging flag we can ask folks to try to narrow down the issue.
Jonah Williams authoredSep 13, 2024 Configuration menu - View commit details
-
Copy full SHA for 8aa8b53 - Browse repository at this point
Copy the full SHA 8aa8b53View commit details -
Roll Skia from 9877f459399a to bdc5e73cb6c9 (1 revision) (#55189)
https://skia.googlesource.com/skia.git/+log/9877f459399a..bdc5e73cb6c9 2024-09-13 [email protected] Revert "Reland "[graphite] Add purge() method to DrawAtlas."" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 7fcef5f - Browse repository at this point
Copy the full SHA 7fcef5fView commit details -
Roll Fuchsia Linux SDK from 3YH1DEYJ-s93fHBw5... to -kKh_AYzPh_iEmTxK…
…... (#55190) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 3808101 - Browse repository at this point
Copy the full SHA 3808101View commit details -
Delete VolatilePathTracker in favor of Dispatch tracking (#55125)
ui.Canvas and ui.SceneBuilder now use the DlPath object directly from the ui.Path object. This results in increased sharing of the wrapper objects which then increases the sharing of both the converted Impeller paths and Skia's volatile flag. The VolatilePathTracker mechanism is deleted and rather than count the number of frames that a path is stable for, instead we count the number of times it is used for rendering. If a path is used 100 times in a single frame, it will become non-volatile and start being cached almost immediately. The cached Impeller paths are now also tracked for all instances of the same path, rather than for each call site that originated from a DisplayList dispatch.
Configuration menu - View commit details
-
Copy full SHA for 3eca8fd - Browse repository at this point
Copy the full SHA 3eca8fdView commit details -
Reverts "[skwasm] Scene builder optimizations for platform view place…
…ment (#54949)" (#55193) Reverts: #54949 Initiated by: eyebrowsoffire Reason for reverting: Incorrect golden diffs on engine roll, see flutter/flutter#155181 Original PR Author: eyebrowsoffire Reviewed By: {harryterkelsen} This change reverts the following previous change: This PR refactors the scene builder's logic in order to more aggressively merge flutter content and platform view content together. This essentially covers the case discussed in this flutter issue: flutter/flutter#149863 This optimization ensures that each picture or platform view is applied to the lowest possible slice in the scene, which avoids the proliferation of redundant slices and overlays in the scene.
Configuration menu - View commit details
-
Copy full SHA for dfb04f3 - Browse repository at this point
Copy the full SHA dfb04f3View commit details -
Roll Dart SDK from 302b6472b849 to c0f7e399ff4a (1 revision) (#55191)
https://dart.googlesource.com/sdk.git/+log/302b6472b849..c0f7e399ff4a 2024-09-13 [email protected] Version 3.6.0-254.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 6477f87 - Browse repository at this point
Copy the full SHA 6477f87View commit details -
Roll Skia from bdc5e73cb6c9 to 2b8e33aa4824 (1 revision) (#55192)
https://skia.googlesource.com/skia.git/+log/bdc5e73cb6c9..2b8e33aa4824 2024-09-13 [email protected] Roll vulkan-deps from 788001a1cbae to b747b6f853ad (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b58992a - Browse repository at this point
Copy the full SHA b58992aView commit details
Commits on Sep 14, 2024
-
Synthesize remove events on
PointerChange.ACTION_UPand `PointerCha……nge.ACTION_POINTER_UP` (#55157) ... when the input device type is touch. Fixes (partially) flutter/flutter#154842 for touch events. Does not fix when using a stylus, that case will require a follow up PR. Without fix: https://github.com/user-attachments/assets/10a8ac73-7b27-498b-a76e-0f2cfc3050d7 With fix: https://github.com/user-attachments/assets/18656f3a-d45a-4b08-9227-cc0abe8c73f7 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 4d8d851 - Browse repository at this point
Copy the full SHA 4d8d851View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff ab9daaa0bcc7...4d8d8517a0ff