Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: aa98a9d2e86f
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 54c64a41a629
Choose a head ref
  • 18 commits
  • 11 files changed
  • 5 contributors

Commits on Aug 24, 2023

  1. Roll Skia from 9d4db3443527 to e3ee267859a7 (1 revision) (#45036) 

    https://skia.googlesource.com/skia.git/+log/9d4db3443527..e3ee267859a7

2023-08-23 [email protected] Revert "Disable Graphite SkSL tests on Linux in Release."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3535a67 View commit details
    Browse the repository at this point in the history

  2. Remove a clang-tidy test that launches a full run of clang-tidy (#45033) 

    This can take a lot of time or be overly dependent on configuration details of the local git repository.
    @jason-simmons
    jason-simmons authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e9122ec View commit details
    Browse the repository at this point in the history

  3. Roll Skia from e3ee267859a7 to 02eecda395ba (1 revision) (#45042) 

    https://skia.googlesource.com/skia.git/+log/e3ee267859a7..02eecda395ba

2023-08-24 [email protected] [skif] Update Blur imagefilter to use new bounds APIs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ab11333 View commit details
    Browse the repository at this point in the history

  4. [Impeller] Add debug captures and inspector. (#43764) 

    Weekend project! Press `C` to capture in the Aiks playground.

Decided to finally give this a go and attempt to relieve some of the print debugging/mindfuck around investigation of coverage-related issues lately. :)

Captures:
* Capture documents from anywhere in Impeller.
* Easily implement inspectors for those documents.
* Replay documents with live editing.
* No overhead when capturing is build time disabled (that's the idea, anyway).
* Low overhead when capturing is runtime disabled.

Aiks inspector:
* Outline passes and rendered entities.
* Identify collapsed passes.
* Visibly highlight coverage.
* Live edit scene properties.

Possible future work:
* Filters!
* Blend mode property.
* Pointer + release proc property.
* Support captures in the DL playground.
* Text atlas visualization.
* Multi-frame capture and scrubbing.
* Menus instead of key bindings?

https://github.com/flutter/engine/assets/919017/a7a63e24-f72f-4140-a21e-6ca02a05fc20
    @bdero
    bdero authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3b92bb6 View commit details
    Browse the repository at this point in the history

  5. Manual roll Dart SDK from ab417bc74bb1 to 87a5a26b25fc (4 revisions) (#… 

    …45043)

Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/ab417bc74bb1..87a5a26b25fc

2023-08-23 [email protected] Version 3.2.0-101.0.dev
2023-08-23 [email protected] Version 3.2.0-100.0.dev
2023-08-23 [email protected] Version 3.2.0-99.0.dev
2023-08-23 [email protected] Version 3.2.0-98.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    eee9105 View commit details
    Browse the repository at this point in the history

  6. Roll Fuchsia Linux SDK from -HcyJtxGxUDcqX-jo... to XoUnFqSvX9mhbXqBJ… 

    …... (#45044)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b5de6f3 View commit details
    Browse the repository at this point in the history

  7. Roll Fuchsia Mac SDK from vJ6oaubpqgRM2nb1e... to P8oeVw3whCGS6pCjL... ( 

    #45046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6a63a5b View commit details
    Browse the repository at this point in the history

  8. Roll Skia from 02eecda395ba to 82472773892d (1 revision) (#45049) 

    https://skia.googlesource.com/skia.git/+log/02eecda395ba..82472773892d

2023-08-24 [email protected] Roll Skia Infra from 07afc72c35f0 to 16dd437ab329 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2222940 View commit details
    Browse the repository at this point in the history

  9. Roll Skia from 82472773892d to 17c0f4b72fcd (1 revision) (#45050) 

    https://skia.googlesource.com/skia.git/+log/82472773892d..17c0f4b72fcd

2023-08-24 [email protected] Roll SK Tool from 16dd437ab329 to 4537cb2543dd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a4a3ce4 View commit details
    Browse the repository at this point in the history

  10. Roll Skia from 17c0f4b72fcd to 317f4c2ba2ca (1 revision) (#45051) 

    https://skia.googlesource.com/skia.git/+log/17c0f4b72fcd..317f4c2ba2ca

2023-08-24 [email protected] Roll ANGLE from aaeeea0c42a8 to 0b648252039f (28 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    35b522d View commit details
    Browse the repository at this point in the history

  11. Roll Skia from 317f4c2ba2ca to 13a050278b1a (1 revision) (#45054) 

    https://skia.googlesource.com/skia.git/+log/317f4c2ba2ca..13a050278b1a

2023-08-24 [email protected] Roll vulkan-deps from 16e38af9947d to 00368bd7466b (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0d2f557 View commit details
    Browse the repository at this point in the history

  12. Roll Skia from 13a050278b1a to 68700a1a2be9 (1 revision) (#45058) 

    https://skia.googlesource.com/skia.git/+log/13a050278b1a..68700a1a2be9

2023-08-24 [email protected] Disable Metal warnings in SkSL.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    43a0cb6 View commit details
    Browse the repository at this point in the history

  13. Roll Skia from 68700a1a2be9 to 994d5e03fa1c (1 revision) (#45059) 

    https://skia.googlesource.com/skia.git/+log/68700a1a2be9..994d5e03fa1c

2023-08-24 [email protected] Remove all Ganesh Dawn jobs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    85d2da0 View commit details
    Browse the repository at this point in the history

  14. Roll Fuchsia Linux SDK from XoUnFqSvX9mhbXqBJ... to 0kEa4JczTMD0Xus08… 

    …... (#45060)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6fac0a2 View commit details
    Browse the repository at this point in the history

  15. Revert "[Impeller] add trace events for VkRenderPass and VkFrameBuffe… ( 

    #45047)

�r creation. (#44837)"

This reverts commit ca4ea82.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

These trace events aren't super useful, since we've tracked down the issues as either 1) phone is overloaded due to image decoding at large size or 2) flutter/flutter#133198
    Jonah Williams authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    327ae3c View commit details
    Browse the repository at this point in the history

  16. Roll Skia from 994d5e03fa1c to e008ee76b890 (1 revision) (#45061) 

    https://skia.googlesource.com/skia.git/+log/994d5e03fa1c..e008ee76b890

2023-08-24 [email protected] Reland "Disable Graphite SkSL tests on Linux in Release."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6f390e3 View commit details
    Browse the repository at this point in the history

  17. [Impeller] Don't place vertex buffer bindings in the Binding map. (#4… 

    …5040)

The metal backend is the only backend that doesn't treat binding the vertex buffer specially. For the GLES and Vulkan backend, we can instead pull it out of the cmd map entirely.

This will make it easier to partially inline the map into the bindings object.

flutter/flutter#133199
    Jonah Williams authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    03b0894 View commit details
    Browse the repository at this point in the history

  18. Revert "[Impeller] Add debug captures and inspector." (#45062) 

    Reverts #43764

Broke the wide gamut test on framework CI
flutter/flutter#133255


https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20wide_gamut_ios/3186/overview
    @zanderso
    zanderso authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    54c64a4 View commit details
    Browse the repository at this point in the history
Loading