Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: aa98a9d2e86f
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3b92bb6eda19
Choose a head ref
  • 4 commits
  • 24 files changed
  • 3 contributors

Commits on Aug 24, 2023

  1. Roll Skia from 9d4db3443527 to e3ee267859a7 (1 revision) (#45036) 

    https://skia.googlesource.com/skia.git/+log/9d4db3443527..e3ee267859a7

2023-08-23 [email protected] Revert "Disable Graphite SkSL tests on Linux in Release."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3535a67 View commit details
    Browse the repository at this point in the history

  2. Remove a clang-tidy test that launches a full run of clang-tidy (#45033) 

    This can take a lot of time or be overly dependent on configuration details of the local git repository.
    @jason-simmons
    jason-simmons authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e9122ec View commit details
    Browse the repository at this point in the history

  3. Roll Skia from e3ee267859a7 to 02eecda395ba (1 revision) (#45042) 

    https://skia.googlesource.com/skia.git/+log/e3ee267859a7..02eecda395ba

2023-08-24 [email protected] [skif] Update Blur imagefilter to use new bounds APIs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ab11333 View commit details
    Browse the repository at this point in the history

  4. [Impeller] Add debug captures and inspector. (#43764) 

    Weekend project! Press `C` to capture in the Aiks playground.

Decided to finally give this a go and attempt to relieve some of the print debugging/mindfuck around investigation of coverage-related issues lately. :)

Captures:
* Capture documents from anywhere in Impeller.
* Easily implement inspectors for those documents.
* Replay documents with live editing.
* No overhead when capturing is build time disabled (that's the idea, anyway).
* Low overhead when capturing is runtime disabled.

Aiks inspector:
* Outline passes and rendered entities.
* Identify collapsed passes.
* Visibly highlight coverage.
* Live edit scene properties.

Possible future work:
* Filters!
* Blend mode property.
* Pointer + release proc property.
* Support captures in the DL playground.
* Text atlas visualization.
* Multi-frame capture and scrubbing.
* Menus instead of key bindings?

https://github.com/flutter/engine/assets/919017/a7a63e24-f72f-4140-a21e-6ca02a05fc20
    @bdero
    bdero authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3b92bb6 View commit details
    Browse the repository at this point in the history
Loading