Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a9be77e6f475
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 16b01b98af20
Choose a head ref
  • 6 commits
  • 49 files changed
  • 6 contributors

Commits on Aug 10, 2023

  1. Roll Skia from 92e6f52b0fa8 to b6492f5ce8c3 (1 revision) (#44597) 

    https://skia.googlesource.com/skia.git/+log/92e6f52b0fa8..b6492f5ce8c3

2023-08-10 [email protected] [bazel] Make use of gcs_mirror_url()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d5db728 View commit details
    Browse the repository at this point in the history

  2. Reintroduce Windows lifecycle with guard for posthumous `OnWindowStat… 

    …eEvent` (#44344)

Previously, destruction of `Window` called `DestroyWindow`, which may
send `WM_KILLFOCUS` to the to-be-destroyed window. Because `Window`'s
destructor is called after `FlutterWindow`'s, the `FlutterWindow` vtable
was already destroyed at this point, and the subsequent call to the
virtual method `OnWindowStateEvent` would cause a crash. This PR
reintroduces the reverted changes for Windows lifecycle with a check
before calling the virtual method that the `FlutterWindow` object has
not yet been destructed.

flutter/flutter#131872

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Loïc Sharma <[email protected]>
    @yaakovschectman @loic-sharma
    yaakovschectman and loic-sharma authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    f53ad9c View commit details
    Browse the repository at this point in the history

  3. Support for Android Platform Views under Impeller/Vulkan (#44571) 

    - Introduce AndroidHardwareBufferTextureSourceVK.
- Enable the necessary Vulkan extensions to support
AndroidHardwareBufferTextureSourceVK.
- Refactor HardwareBufferExternalTextureGL into a base class and a GL
and VK specializations.
- Switch ImageReaderPlatformView to use the PRIVATE image format
(enables DRM'd content to be captured in the texture).
- Add a AHardwareBuffer_describe to NDKHelpers.
- Misc cleanups.
    @johnmccutchan
    johnmccutchan authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6445507 View commit details
    Browse the repository at this point in the history

  4. Reland "Android a11y bridge sets importantness" (#44589) 

    The previous pr was reverted due to test failures. The failure was due to API not supported in order android version. The fix is in the second commit.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @chunhtai
    chunhtai authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    69675f6 View commit details
    Browse the repository at this point in the history

  5. Fix unexpected pointer change issue and Add test case (#43949) 

    Fix issue 129765 and Add test case, see  issue
Fixes flutter/flutter#129765

- [�] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [�] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [�] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [�] I listed at least one issue that this PR fixes in the description above.
- [�] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
- [�] I updated/added relevant documentation (doc comments with `///`).
- [�] I signed the [CLA].
- [ �] All existing and new tests are passing.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @LoveJello
    LoveJello authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0795adf View commit details
    Browse the repository at this point in the history

  6. Roll Dart SDK from 46da53e7abe2 to a2eac00da6b8 (1 revision) (#44601) 

    https://dart.googlesource.com/sdk.git/+log/46da53e7abe2..a2eac00da6b8

2023-08-10 [email protected] Version 3.2.0-58.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    16b01b9 View commit details
    Browse the repository at this point in the history
Loading