Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a966cf878ffd
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3fc40ca5beb9
Choose a head ref
  • 3 commits
  • 6 files changed
  • 3 contributors

Commits on Feb 16, 2023

  1. [macOS] Improve TextInputPlugin test readability (#39664) 

    This just extracts arguments to the TextInputClient.setClient async
method call into an NSDictionary local to reduce the deep
indentation of the formatted code.

While the bulk of these calls are identical and could be extracted to a
utility function, or a class extension method like
`handleDefaultSetClientCall`, the point of these tests is to exercise
FlutterTextInputPlugin, and the message protocol over the channel are
precisely what's  being tested, so it makes sense to keep these
explicit.

Followup patch to #39632.

Issue: flutter/flutter#120252
    @cbracken
    cbracken authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b7ec9ce View commit details
    Browse the repository at this point in the history

  2. Roll Dart SDK from a594e34e85b6 to ce9397c5fc8f (1 revision) (#39667) 

    https://dart.googlesource.com/sdk.git/+log/a594e34e85b6..ce9397c5fc8f

2023-02-15 [email protected] Version 3.0.0-241.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    a6e8fb1 View commit details
    Browse the repository at this point in the history

  3. ++ (#39617)

    @luckysmg
    luckysmg authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    3fc40ca View commit details
    Browse the repository at this point in the history
Loading