Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a8fb9daae8d0
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c2ef01f6f1ab
Choose a head ref
  • 3 commits
  • 13 files changed
  • 3 contributors

Commits on May 20, 2024

  1. Roll Dart SDK from 54c384453207 to 08f4324c988b (1 revision) (#52931) 

    https://dart.googlesource.com/sdk.git/+log/54c384453207..08f4324c988b

2024-05-20 [email protected] Version 3.5.0-172.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 20, 2024
    Configuration menu
    Copy the full SHA
    1daa271 View commit details
    Browse the repository at this point in the history

  2. [Impeller] leave glyph atlas in transfer dst to improve vulkan throug… 

    …hput. (#52908)

On the vulkan backend everytime we blit a glyph we go shader read -> transfer dst -> shader read. This is pretty inefficient if we're appending many glyphs. 

Poke a hole in the blitpass API so we can leave the glyph atlas in transfer_dst to reduce the number of layout transitions.
    Jonah Williams authored May 20, 2024
    Configuration menu
    Copy the full SHA
    8eba63f View commit details
    Browse the repository at this point in the history

  3. Update file permissions for FlutterMacOS.framework (#52930) 

    During FlutterMacOS.framework engine universal fat framework creation, make sure the framework is `u=rwx,go=rx` when it's created.

There's a framework-side workaround in-flight flutter/flutter#148580. 

However, this is still a good thing to do engine-side, particularly for add-to-app when they don't go through the `flutter assemble` tooling.

I'll also add a test around here, once this rolls https://github.com/flutter/flutter/blob/02a6c91e4d37d28f42c8f8e4d4335b0defed41c1/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart#L30

Fixes flutter/flutter#148354

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @jmagman
    jmagman authored May 20, 2024
    Configuration menu
    Copy the full SHA
    c2ef01f View commit details
    Browse the repository at this point in the history
Loading