Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a6e37bde65fd
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ccf50f344d5d
Choose a head ref
  • 7 commits
  • 29 files changed
  • 5 contributors

Commits on May 23, 2023

  1. Roll Skia from 3ded22186598 to 225d51031ad0 (1 revision) (#42246) 

    https://skia.googlesource.com/skia.git/+log/3ded22186598..225d51031ad0

2023-05-23 [email protected] Make codec registration for decoding explicit

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 23, 2023
    Configuration menu
    Copy the full SHA
    54e92c4 View commit details
    Browse the repository at this point in the history

  2. [web] Move platformViewRegistry to ui_web (#41877) 

    In this PR, I'm leaving a getter for `platformViewRegistry` in `dart:ui` for backwards compatibility. At some point, we need to properly deprecate it (e.g. print a warning asking users to import it from `dart:ui_web` instead).

Next step is to migrate all call sites in flutter/flutter, flutter/packages and flutter/devtools (anything else?).

Issue: flutter/flutter#126831

Fixes flutter/flutter#41563
    @mdebbar
    mdebbar authored May 23, 2023
    Configuration menu
    Copy the full SHA
    f37e78c View commit details
    Browse the repository at this point in the history

  3. Roll watcher dependency for web_ui to 1.1.0. (#42248) 

    Incoming dart sdk roll
https://dart.googlesource.com/sdk.git/+log/90b4df96e9dc..4881eadbade6
needs updated version of watcher due to FileSystemEvent becoming sealed.
    @aam
    aam authored May 23, 2023
    Configuration menu
    Copy the full SHA
    e9d1310 View commit details
    Browse the repository at this point in the history

  4. Build arm64 FlutterEmbedder.framework and lipo the result (#42233) 

    This PR modifies the mac_host_engine build config to build the
FlutterEmbedder.framework for arm64, and adds a generator that creates a
fat framework containing both the intel and arm64 dylibs. The fat
framework is uploaded to the gcs bucket instead of the thin intel-only
one.

The script to create the lipo'd embedder framework is different enough
from the desktop framework to have a separate script, but this still
triggers the pylint duplicate-code check. Due to a bug in our version of
pylint (pylint-dev/pylint#214), it isn't
possible to disable per-file, so this PR also disables the check
globally.
    @zanderso
    zanderso authored May 23, 2023
    Configuration menu
    Copy the full SHA
    268c0e1 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 225d51031ad0 to 292879d286e9 (5 revisions) (#42249) 

    https://skia.googlesource.com/skia.git/+log/225d51031ad0..292879d286e9

2023-05-23 [email protected] Removing an extra (wrong) placeholder for CLIENT_ICU
2023-05-23 [email protected] Revert "[skif] Remove dedicated SkDropShadowImageFilter implementation"
2023-05-23 [email protected] [skif] Remove legacy SkImageImageFilter implementation
2023-05-23 [email protected] Reland "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"
2023-05-23 [email protected] Reland "[skif] Add FilterResult::Builder and update SkMergeImageFilter to use it"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 23, 2023
    Configuration menu
    Copy the full SHA
    9bcf529 View commit details
    Browse the repository at this point in the history

  6. [Impeller] Removed last ivars to raw vk::Device's. (#42215) 

    Removes the last ivars that hold onto a `Device` directly.  This have recently been the cause of crashes, so the safer thing is to remove them all.

For the Allocator and the Sampler library, removing the device ivars is likely just a precaution since they should have only been accessed from the raster thread and killed before the Device.  The fence waiter however was potentially accessing the device from a separate thread, so that was much more risky and likely to cause crashes.

Testing: The existing `impeller_unittests` verify this is setup correctly.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored May 23, 2023
    Configuration menu
    Copy the full SHA
    fa44648 View commit details
    Browse the repository at this point in the history

  7. Roll Fuchsia Linux SDK from Zbd3haNY2Idcdu1Fj... to -dXJ_pnUVwmjscIYm… 

    …... (#42250)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 23, 2023
    Configuration menu
    Copy the full SHA
    ccf50f3 View commit details
    Browse the repository at this point in the history
Loading