This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.

...

compare: 37f68f6fc7fc

1 commit
2 files changed
1 contributor

Commits on Jan 23, 2024

Change how OpenGL textures are flipped in the Android embedder. (#49938 )

h/t @bdero for [writing the actual
code](flutter/flutter#141636 (comment))
(I just wrote comments).

Manual test[^1] of `cd
packages/packages/video_player/video_player/example && flutter run`:

## Skia

![Screenshot 2024-01-22 at 3 21
20 PM](https://github.com/flutter/engine/assets/168174/f1023251-4b44-47f3-94f8-1d5dced7bcb3)

## Impeller + OpenGL

![Screenshot 2024-01-22 at 9 41
59 AM](https://github.com/flutter/engine/assets/168174/a2bed578-c929-4222-a1f9-010e2dc95b7e)

```xml
<meta-data
      android:name="io.flutter.embedding.android.EnableImpeller"
      android:value="true" />
<meta-data
      android:name="io.flutter.embedding.android.ImpellerBackend"
      android:value="opengles" />
```

Closes flutter/flutter#141636.

[^1]: I can't write a test worth writing at the same time of this PR, so
I've filed flutter/flutter#141973 to do it
after.

matanlurey authored Jan 23, 2024