Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9ccd81d7595b
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 20e53614c16c
Choose a head ref
  • 3 commits
  • 41 files changed
  • 3 contributors

Commits on Jan 31, 2024

  1. [web] Final nail in FlutterViewEmbedder's coffin (#49769) 

    - Extracted `ResourceManager` out of `FlutterViewEmbedder`.
- Extracted `GlobalHtmlAttributes` out of `FlutterViewEmbedder`.
- Removed usages of:
    - `FlutterViewEmbedder.reset()`.
    - `flutterViewEmbedder`.
    - `ensureFlutterViewEmbedderInitialized`.
- Deleted `FlutterViewEmbedder`.

Fixes flutter/flutter#134443
    @mdebbar
    mdebbar authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    94a27b3 View commit details
    Browse the repository at this point in the history

  2. Log FlutterJSONMessageCodec decode errors before asserting (#50163) 

    Logging JSON decode errors on assertion will help track down bugs.
flutter/flutter#100891 (comment)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @jmagman
    jmagman authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    70b9d31 View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from fbf1d8ebceb4 to 1f136c7b962d (1 revision) (#50203) 

    https://dart.googlesource.com/sdk.git/+log/fbf1d8ebceb4..1f136c7b962d

2024-01-31 [email protected] Version 3.4.0-96.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    20e5361 View commit details
    Browse the repository at this point in the history
Loading