-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: 9b51e30a4d37
head repository: flutter/engine
compare: 5eedfefe38c1
- 12 commits
- 251 files changed
- 7 contributors
Commits on Dec 12, 2024
-
[web] Use CanvasKit to run tests under engine/ (#54786)
Let's start running the tests under `engine/` using the CanvasKit renderer instead of HTML. This PR also: - Moves several tests from `engine/` to `html/` since they were testing html-specific stuff. - Deletes `test/canvaskit/semantics_test.dart` since it's just an "alias" for `test/engine/semantics/semantics_test.dart`.
Configuration menu - View commit details
-
Copy full SHA for 32f1e6d - Browse repository at this point
Copy the full SHA 32f1e6dView commit details -
Migrate layers and layer_tree to DisplayList/Impeller geometry classes (
#57153) Migrates Layers and LayerTree and parts of the `flow/` utility classes to use DlGeometry (Impeller) classes.
Configuration menu - View commit details
-
Copy full SHA for f100e64 - Browse repository at this point
Copy the full SHA f100e64View commit details -
Migrate FlBasicMessageChannel tests to FlMockBinaryMessenger (#57115)
Use FlMockBinaryMessenger instead of mocking the whole engine.
Configuration menu - View commit details
-
Copy full SHA for c5962d1 - Browse repository at this point
Copy the full SHA c5962d1View commit details -
Migrate FlPlatformChannel tests to FlMockBinaryMessenger (#57140)
Use FlMockBinaryMessenger instead of mocking the whole engine.
Configuration menu - View commit details
-
Copy full SHA for 4fd9855 - Browse repository at this point
Copy the full SHA 4fd9855View commit details -
Roll Fuchsia Linux SDK from HJ57Y3zxqDamI8qkY... to iWMEbVYaNdH8RJmXZ…
…... (#57163) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for e291650 - Browse repository at this point
Copy the full SHA e291650View commit details -
Make fl_engine_send_key_event into a standard async function. (#57112)
Add missing tests for this function. Note this makes FlKeyboardManager a bit more complex, but this is planned to be simplified in a future refactor.
Configuration menu - View commit details
-
Copy full SHA for 3bba62b - Browse repository at this point
Copy the full SHA 3bba62bView commit details -
[Impeller] dont print format strings for blend filter and snapshots. (#…
…57105) We can use a macro to distinguish between all of the blend modes. We don't need to distinguish between porter duff/ advanced /pipeline as the pipeline is already labeled with the shader used. For all snapshots the additional label on the texture isn't useful since we can just look at the command.
Jonah Williams authoredDec 12, 2024 Configuration menu - View commit details
-
Copy full SHA for 7ec5b81 - Browse repository at this point
Copy the full SHA 7ec5b81View commit details -
Reenabled labelling test with a capabilities check. (#57160)
fixes flutter/flutter#160180 I'm unable to reproduce the problem locally but this is the most likely cause. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for ec8326c - Browse repository at this point
Copy the full SHA ec8326cView commit details -
[Impeller] exploit perfect hash for SamplerDescriptor. (#57036)
There are only 3 or 4 sampler's active at any given time in a flutter app. rather than store them in a hashmap, just use a vector.
Jonah Williams authoredDec 12, 2024 Configuration menu - View commit details
-
Copy full SHA for ff8dfad - Browse repository at this point
Copy the full SHA ff8dfadView commit details -
removed c style casts and enabled the lint (#57162)
test exempt: should have no functional change ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/engine/blob/main/docs/testing/Testing-the-engine.md [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
Configuration menu - View commit details
-
Copy full SHA for 93b7c61 - Browse repository at this point
Copy the full SHA 93b7c61View commit details
Commits on Dec 13, 2024
-
[ios]enable the webview non tappable workaround by checking subviews …
…recursively (#57168) The original workaround ([PR](#56804)) works for the official web view plugin, but it doesn't work for a third party plugin `flutter_inappwebview` ([issue](https://github.com/pichillilorenzo/flutter_inappwebview)). Upon discussion with the author of that plugin, it turns out that their platform view is not a WKWebView, but rather a wrapper of WKWebView. This PR performs a DFS search of the view hierarchy, and enable the workaround as long as there's a WKWebView inside. TODO: pending sample project: I am quite positive that it should work, but **I haven't tried it since I don't have a sample project yet**. I have requested a sample project with them so I can verify the solution. *List which issues are fixed by this PR. You must list at least one issue.* pichillilorenzo/flutter_inappwebview#2415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 4402232 - Browse repository at this point
Copy the full SHA 4402232View commit details -
Normalize round rect bounds when coming from Flutter (#57171)
A flaw in #57153 - SkRRect would normalize the rect (make it right-side up), a feature that Flutter code takes advantage of. We need to do that manually when we ingest a round rect from Flutter.
Configuration menu - View commit details
-
Copy full SHA for 5eedfef - Browse repository at this point
Copy the full SHA 5eedfefView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 9b51e30a4d37...5eedfefe38c1