Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9b51e30a4d37
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5eedfefe38c1
Choose a head ref
  • 12 commits
  • 251 files changed
  • 7 contributors

Commits on Dec 12, 2024

  1. [web] Use CanvasKit to run tests under engine/ (#54786)

    Let's start running the tests under `engine/` using the CanvasKit renderer instead of HTML.
    
    This PR also:
    - Moves several tests from `engine/` to `html/` since they were testing html-specific stuff.
    - Deletes `test/canvaskit/semantics_test.dart` since it's just an "alias" for `test/engine/semantics/semantics_test.dart`.
    mdebbar authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    32f1e6d View commit details
    Browse the repository at this point in the history
  2. Migrate layers and layer_tree to DisplayList/Impeller geometry classes (

    #57153)
    
    Migrates Layers and LayerTree and parts of the `flow/` utility classes to use DlGeometry (Impeller) classes.
    flar authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    f100e64 View commit details
    Browse the repository at this point in the history
  3. Migrate FlBasicMessageChannel tests to FlMockBinaryMessenger (#57115)

    Use FlMockBinaryMessenger instead of mocking the whole engine.
    robert-ancell authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    c5962d1 View commit details
    Browse the repository at this point in the history
  4. Migrate FlPlatformChannel tests to FlMockBinaryMessenger (#57140)

    Use FlMockBinaryMessenger instead of mocking the whole engine.
    robert-ancell authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    4fd9855 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e291650 View commit details
    Browse the repository at this point in the history
  6. Make fl_engine_send_key_event into a standard async function. (#57112)

    Add missing tests for this function.
    
    Note this makes FlKeyboardManager a bit more complex, but this is
    planned to be simplified in a future refactor.
    robert-ancell authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    3bba62b View commit details
    Browse the repository at this point in the history
  7. [Impeller] dont print format strings for blend filter and snapshots. (#…

    …57105)
    
    We can use a macro to distinguish between all of the blend modes. We don't need to distinguish between porter duff/ advanced /pipeline as the pipeline is already labeled with the shader used.
    
    For all snapshots the additional label on the texture isn't useful since we can just look at the command.
    Jonah Williams authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    7ec5b81 View commit details
    Browse the repository at this point in the history
  8. Reenabled labelling test with a capabilities check. (#57160)

    fixes flutter/flutter#160180
    
    I'm unable to reproduce the problem locally but this is the most likely cause.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    gaaclarke authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    ec8326c View commit details
    Browse the repository at this point in the history
  9. [Impeller] exploit perfect hash for SamplerDescriptor. (#57036)

    There are only 3 or 4 sampler's active at any given time in a flutter app. rather than store them in a hashmap, just use a vector.
    Jonah Williams authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    ff8dfad View commit details
    Browse the repository at this point in the history
  10. removed c style casts and enabled the lint (#57162)

    test exempt: should have no functional change
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I signed the [CLA].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/engine/blob/main/docs/testing/Testing-the-engine.md
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
    gaaclarke authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    93b7c61 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2024

  1. [ios]enable the webview non tappable workaround by checking subviews …

    …recursively (#57168)
    
    The original workaround ([PR](#56804)) works for the official web view plugin, but it doesn't work for a third party plugin `flutter_inappwebview` ([issue](https://github.com/pichillilorenzo/flutter_inappwebview)). Upon discussion with the author of that plugin, it turns out that their platform view is not a WKWebView, but rather a wrapper of WKWebView. 
    
    This PR performs a DFS search of the view hierarchy, and enable the workaround as long as there's a WKWebView inside. 
    
    TODO: pending sample project:
    I am quite positive that it should work, but **I haven't tried it since I don't have a sample project yet**. I have requested a sample project with them so I can verify the solution. 
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    
     pichillilorenzo/flutter_inappwebview#2415
    
    *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    hellohuanlin authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    4402232 View commit details
    Browse the repository at this point in the history
  2. Normalize round rect bounds when coming from Flutter (#57171)

    A flaw in #57153 - SkRRect would normalize the rect (make it right-side up), a feature that Flutter code takes advantage of. We need to do that manually when we ingest a round rect from Flutter.
    flar authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    5eedfef View commit details
    Browse the repository at this point in the history
Loading