Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 98b6fabc66bb
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2a84ea55e4ef
Choose a head ref
  • 10 commits
  • 26 files changed
  • 8 contributors

Commits on Apr 28, 2023

  1. Roll Skia from 05d09f28250a to 9867fa253064 (18 revisions) (#41584) 

    https://skia.googlesource.com/skia.git/+log/05d09f28250a..9867fa253064

2023-04-28 [email protected] feat(*): add entry points for canvaskit
2023-04-28 [email protected] Remove Ganesh and Graphite code from SkImage::subset
2023-04-28 [email protected] Roll ANGLE from 5c0b4251bd2c to adf21a927515 (8 revisions)
2023-04-28 [email protected] Roll SwiftShader from 3076b4c0d8ce to f0d31e0f4846 (1 revision)
2023-04-28 [email protected] Roll Skia Infra from 3007135dd349 to a51a80d7ae5a (12 revisions)
2023-04-28 [email protected] Roll vulkan-deps from a8c2037f213a to 14eaf973d52a (12 revisions)
2023-04-27 [email protected] Roll SK Tool from 3007135dd349 to 575bfadf099e
2023-04-27 [email protected] [graphite] BufferManager: Rename `mappable` and fix AccessPattern setting
2023-04-27 [email protected] Remove AVX512 (SKX) logic from RasterPipeline_opts
2023-04-27 [email protected] Remove unused AVX512 opts code
2023-04-27 [email protected] Eliminate redundant constant-stores to the same range in SkRP.
2023-04-27 [email protected] Remove affine bitmap procs
2023-04-27 [email protected] Detect invalid layout(push_constant) modifier.
2023-04-27 [email protected] [graphite] BufferManager: support pre-zeroed storage buffer creation
2023-04-27 [email protected] Use push-pop simplification in many more places.
2023-04-27 [email protected] Print which pixel format was requested in abort message
2023-04-27 [email protected] [skif] Add inverseMapRect to LayerSpace<SkMatrix>
2023-04-27 [email protected] Change copyright of presubmit tests to Google Inc.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    3bd6435 View commit details
    Browse the repository at this point in the history

  2. Replace deprecated and internal Skia EncodedImage calls with public v… 

    …ersions (#41368)

Skia would like to remove `SkImageGenerator::MakeFromEncoded` and this
appears to be the only remaining usage. It appears to be easily swapped
out for the `SkImages::DeferredFromEncodedData`. (skbug.com/13052)

This also removes the use of the internal `SkCodecImageGenerator` for
the public `SkCodec` API (which the image generator had just been
deferring to anyway).

While unbreaking some unit tests, I made a few assertions easier to
debug and produce nicer error messages.
    @kjlubick
    kjlubick authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    fe4a6f2 View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from c7160d4ea0b7 to 8e9bf2bb9878 (5 revisions) (#41586) 

    https://dart.googlesource.com/sdk.git/+log/c7160d4ea0b7..8e9bf2bb9878

2023-04-28 [email protected] Version 3.1.0-54.0.dev
2023-04-28 [email protected] Version 3.1.0-53.0.dev
2023-04-28 [email protected] Version 3.1.0-52.0.dev
2023-04-27 [email protected] Version 3.1.0-51.0.dev
2023-04-27 [email protected] Version 3.1.0-50.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    788fb79 View commit details
    Browse the repository at this point in the history

  4. fuchsia: do not read version_history.json (#41585) 

    Otherwise this causes GN to read JSON files that are irrelevant.

Co-authored-by: Marc-Antoine Ruel <[email protected]>
    @maruel
    maruel and Marc-Antoine Ruel authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ca5b012 View commit details
    Browse the repository at this point in the history

  5. [Impeller] Always enable validation for goldens (#41574) 

    Enable validation for release builds of the golden tests.
    @bdero
    bdero authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    797b352 View commit details
    Browse the repository at this point in the history

  6. Increase timeout for clang-tidy on mac (#41588) 

    These builds are affected by
flutter/flutter#119750

The timeout needs to be increased to avoid the autorollers closing PRs
due to timeouts.
    @zanderso
    zanderso authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    b883217 View commit details
    Browse the repository at this point in the history

  7. Determine lifecycle by looking at window focus also (#41094) 

    ## Description

This incorporates additional signal from `Activity.onWindowFocusChanged` to help decide if the application is `resumed` or `inactive`.

When the user pulls down the notification shade or opens the app switcher in iOS, then iOS sends a notification to the application that it no longer has input focus (is no longer "active" in Apple terminology). 

However, Android (at least on a Pixel) doesn't send `onPause` and `onResume` events for these things, as one might expect. Instead, this PR changes things so that we listen to `Activity.onWindowFocusChanged` and see if any of the windows still have focus.

If it doesn't have focus, then the lifecycle switches to `inactive` (even if `onPause` hasn't been called), and if it does have focus (and `onResume` hasn't been called) then we should go to `resumed`.

State changes are determined and deduped in the `LifecycleChannel` class.

Here's the old state table:

| Android State | Flutter state |
| ------------- | ------------- |
| Resumed  | resumed |
| Paused  | inactive |
| Stopped | paused |
| Detached | detached |

Here's the new state table:

| Android State | Window focused | Flutter state |
| ------------- | ------------- | ------------- |
| Resumed  | true  | resumed |
| Resumed  | false  | _inactive_ * |
| Paused  | true  | inactive |
| Paused  | false  | inactive |
| Stopped  | true  | paused |
| Stopped | false  | paused |
| Detached | true  | detached |
| Detached | false  | detached |

* = This is the relevant change in this PR.

("Window focused" means one or more windows managed by Flutter are focused)

The `inactive` state is for when the application is running and visible, but doesn't have the input focus.  An example where this currently happens are when a phone call is in progress on top of the app, or on some OEMs when going into the app switcher (I've tested on Realme and it does that, at least).  With the PR, it will also go into `inactive` when the app has lost input focus, but is still in the Android `onResume` state. This means that on phones that don't pause the app when they go into the app switcher or the notification window shade (Pixel, others), the app will go into `inactive` when it didn't before. If developers weren't doing anything special in the `inactive` state before, then this PR will have no change for them. If they were, they will go into that state more often (but more consistently across OEMs).

## Related Issues

  - Fixes  flutter/flutter#124591

## Tests

  - Added unit tests for handling `onWindowFocusChanged`.
    @gspencergoog
    gspencergoog authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    eb68df6 View commit details
    Browse the repository at this point in the history

  8. [platform_view] Only dispose view when it is removed from the composi… 

    …tion order (#41521)

DisposeView happens every frame before laying out PlatformViews, with the order specified in `composition_order_`. Because `view_to_dispose_` is determined on UI thread and `composition_order_` is determined on the platform thread, there could be a race if the dart code on the UI thread runs faster than the rasterizer on the Platform thread, causing a view in `view_to_dispose_` is still in the `composition_order_`.

This PR delays the views in the `composition_order_` being disposed and wait for the next frame to dispose them. 

fixes flutter/flutter#125223

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d6bc5c5 View commit details
    Browse the repository at this point in the history

  9. Roll buildroot to c96c9d4 (#41589) 

    git log --date=short --format="%ad %ae %s" 5708f20..c96c9d4 2023-04-28 [email protected] fuchsia: do not read json unless enabled (#725) 2023-04-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.1 to 2.3.2 (#724) 2023-04-27 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.0 to 2.3.1 (#723)"
    @maruel
    maruel authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    4b380b9 View commit details
    Browse the repository at this point in the history

  10. Revert "Replace deprecated and internal Skia EncodedImage calls with … 

    …public versions" (#41595)

Reverts #41368

This is blocking rolls into the framework. Let's revert until we sort
out whether there's a workaround for the change to the unpremultiplied
alpha issue.
    @zanderso
    zanderso authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    2a84ea5 View commit details
    Browse the repository at this point in the history
Loading